Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 9307067: Make IllegalArgumentException more forgiving about its arguments. (Closed)

Created:
8 years, 10 months ago by turnidge
Modified:
8 years, 10 months ago
Reviewers:
jjb, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Make IllegalArgumentException more forgiving about its arguments. Committed: https://code.google.com/p/dart/source/detail?r=3858

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M corelib/src/exceptions.dart View 1 2 chunks +4 lines, -4 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
turnidge
8 years, 10 months ago (2012-02-02 18:05:07 UTC) #1
jjb
lgtm https://chromiumcodereview.appspot.com/9307067/diff/1/corelib/src/exceptions.dart File corelib/src/exceptions.dart (right): https://chromiumcodereview.appspot.com/9307067/diff/1/corelib/src/exceptions.dart#newcode1 corelib/src/exceptions.dart:1: // Copyright (c) 2011, the Dart project authors. ...
8 years, 10 months ago (2012-02-02 18:36:25 UTC) #2
siva
https://chromiumcodereview.appspot.com/9307067/diff/4001/corelib/src/exceptions.dart File corelib/src/exceptions.dart (right): https://chromiumcodereview.appspot.com/9307067/diff/4001/corelib/src/exceptions.dart#newcode76 corelib/src/exceptions.dart:76: final _arg; What is our normal style in library ...
8 years, 10 months ago (2012-02-02 19:55:24 UTC) #3
turnidge
8 years, 10 months ago (2012-02-13 21:13:58 UTC) #4
https://chromiumcodereview.appspot.com/9307067/diff/4001/corelib/src/exceptio...
File corelib/src/exceptions.dart (right):

https://chromiumcodereview.appspot.com/9307067/diff/4001/corelib/src/exceptio...
corelib/src/exceptions.dart:76: final _arg;
I recall that it didn't let me use "var" here, but perhaps I'm remembering
incorrectly.

On 2012/02/02 19:55:24, asiva wrote:
> What is our normal style in library code, if we don't want to specify a type
do
> we use 'var'
> e.g:
> final var _arg;

Powered by Google App Engine
This is Rietveld 408576698