Issue 9307033: Revert "Changes to the process implementation."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9307033: Revert "Changes to the process implementation." (Closed)

Created:
8 years, 10 months ago by Mads Ager (google)

Modified:
8 years, 10 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Revert "Changes to the process implementation." There is a race-condition on Windows and exit handling when a process has been closed is incorrect. R=sgjesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=3790

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+104 lines, -341 lines)			Patch
M	runtime/bin/builtin_natives.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/bin/main.cc	View	2 chunks	+1 line, -8 lines	0 comments	Download
M	runtime/bin/process.h	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	runtime/bin/process.cc	View	2 chunks	+9 lines, -1 line	0 comments	Download
M	runtime/bin/process_impl.dart	View	3 chunks	+11 lines, -4 lines	0 comments	Download
M	runtime/bin/process_linux.cc	View	6 chunks	+4 lines, -28 lines	0 comments	Download
M	runtime/bin/process_macos.cc	View	6 chunks	+4 lines, -28 lines	0 comments	Download
M	runtime/bin/process_win.cc	View	7 chunks	+75 lines, -272 lines	0 comments	Download
M	tools/testing/bin/linux/dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	tools/testing/bin/macos/dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	tools/testing/bin/windows/dart.exe	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Total messages: 1 (0 generated)

lgtm