Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 9307010: Type Variables cannot be used in identifier expressions (Closed)

Created:
8 years, 10 months ago by zundel
Modified:
8 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Type Variables cannot be used in identifier expressions dartc was allowing this code to get through to code generation. http://code.google.com/p/dart/issues/detail?id=1387 Committed: https://code.google.com/p/dart/source/detail?r=3757

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -22 lines) Patch
M compiler/java/com/google/dart/compiler/resolver/Resolver.java View 2 chunks +43 lines, -22 lines 1 comment Download
M compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language.status View 1 chunk +1 line, -0 lines 0 comments Download
A tests/language/src/TypeVariableIdentifierExpressionNegativeTest.dart View 1 chunk +25 lines, -0 lines 1 comment Download
M tests/language/src/TypeVariableShadowsClass.dart View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
zundel
8 years, 10 months ago (2012-01-31 20:41:26 UTC) #1
zundel
An alternative to this change I thought of was to create a separate lookup function, ...
8 years, 10 months ago (2012-01-31 20:51:58 UTC) #2
scheglov
8 years, 10 months ago (2012-01-31 20:56:18 UTC) #3
LGTM

https://chromiumcodereview.appspot.com/9307010/diff/1/compiler/java/com/googl...
File compiler/java/com/google/dart/compiler/resolver/Resolver.java (right):

https://chromiumcodereview.appspot.com/9307010/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/resolver/Resolver.java:1031: * Possibly
rescursive check on the resolved identifier.
re_s_cursive

https://chromiumcodereview.appspot.com/9307010/diff/1/tests/language/src/Type...
File tests/language/src/TypeVariableIdentifierExpressionNegativeTest.dart
(right):

https://chromiumcodereview.appspot.com/9307010/diff/1/tests/language/src/Type...
tests/language/src/TypeVariableIdentifierExpressionNegativeTest.dart:6: // This
te
not finished comment

Powered by Google App Engine
This is Rietveld 408576698