Issue 9307003: Changes to the process implementation.

Issue 9307003: Changes to the process implementation. (Closed)

Created:
8 years, 10 months ago by Mads Ager (google)

Modified:
8 years, 10 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Changes to the process implementation. - Make the list of active processes thread safe on Windows. - Use only one thread on Windows to detect process termination. - Stop the process termination thread when the standalone VM terminates. R=sgjesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=3780

Patch Set 1 #

Patch Set 2 : Finish mac and linux part. #

Patch Set 3 : Fix typo #

Patch Set 4 : Close the wake-up handle at the right time. #

Total comments: 6

Patch Set 5 : Address comments. #

Patch Set 6 : Update stable test binaries #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+341 lines, -104 lines)			Patch
M	runtime/bin/builtin_natives.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/bin/main.cc	View		2 chunks	+8 lines, -1 line	0 comments	Download
M	runtime/bin/process.h	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	runtime/bin/process.cc	View		2 chunks	+1 line, -9 lines	0 comments	Download
M	runtime/bin/process_impl.dart	View	1	3 chunks	+4 lines, -11 lines	0 comments	Download
M	runtime/bin/process_linux.cc	View	1 2 3 4	6 chunks	+28 lines, -4 lines	0 comments	Download
M	runtime/bin/process_macos.cc	View	1 2 3 4	6 chunks	+28 lines, -4 lines	0 comments	Download
M	runtime/bin/process_win.cc	View	1 2 3 4	7 chunks	+272 lines, -75 lines	0 comments	Download
M	tools/testing/bin/linux/dart	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	tools/testing/bin/macos/dart	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	tools/testing/bin/windows/dart.exe	View		0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://chromiumcodereview.appspot.com/9307003/diff/5001/runtime/bin/process_linux.cc File runtime/bin/process_linux.cc (right): https://chromiumcodereview.appspot.com/9307003/diff/5001/runtime/bin/process_linux.cc#newcode110 runtime/bin/process_linux.cc:110: static const char kTerminateByte = 1; uint8_t? https://chromiumcodereview.appspot.com/9307003/diff/5001/runtime/bin/process_win.cc ...

8 years, 10 months ago (2012-02-01 07:39:17 UTC) #2

Mads Ager (google)

8 years, 10 months ago (2012-02-01 09:08:56 UTC) #3

Thanks. Addressed comments and updated stable test binaries.

https://chromiumcodereview.appspot.com/9307003/diff/5001/runtime/bin/process_...
File runtime/bin/process_linux.cc (right):

https://chromiumcodereview.appspot.com/9307003/diff/5001/runtime/bin/process_...
runtime/bin/process_linux.cc:110: static const char kTerminateByte = 1;
On 2012/02/01 07:39:17, Søren Gjesse wrote:
> uint8_t?

Done.

https://chromiumcodereview.appspot.com/9307003/diff/5001/runtime/bin/process_...
File runtime/bin/process_win.cc (right):

https://chromiumcodereview.appspot.com/9307003/diff/5001/runtime/bin/process_...
runtime/bin/process_win.cc:216: HANDLE wake_up_event =
reinterpret_cast<HANDLE>(param);
On 2012/02/01 07:39:17, Søren Gjesse wrote:
> Maybe move  he line
> 
> HANDLE wake_up_event ...
> 
> out of the loop.

Done.

https://chromiumcodereview.appspot.com/9307003/diff/5001/runtime/bin/process_...
runtime/bin/process_win.cc:265: int message[3] = { exit_code, negative };
On 2012/02/01 07:39:17, Søren Gjesse wrote:
> 3 -> 2.

Whoops. Good catch!

Expand Messages | Collapse Messages