Issue 9303033: Two different classes may have the same *name*.

Issue 9303033: Two different classes may have the same name. (Closed)

Created:
8 years, 10 months ago by ahe

Modified:
8 years, 10 months ago

Reviewers:
ngeoffray, zundel

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Two different classes may have the same *name*. Committed: https://code.google.com/p/dart/source/detail?r=3725

Patch Set 2 : null.toString() is also broken #

Total comments: 2

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -9 lines)			Patch
M	dart/compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java	View	1	2 chunks	+19 lines, -0 lines	2 comments	Download
M	dart/compiler/java/com/google/dart/compiler/resolver/Resolver.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	dart/compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	dart/tests/utils/utils.status	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	dart/utils/uri/uri.dart	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://chromiumcodereview.appspot.com/9303033/diff/4001/dart/compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java File dart/compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java (right): https://chromiumcodereview.appspot.com/9303033/diff/4001/dart/compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java#newcode224 dart/compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java:224: if (checkString(lhs, lhsType) && checkString(rhs, rhsType)) { You ...

8 years, 10 months ago (2012-01-31 13:17:40 UTC) #4

ahe

https://chromiumcodereview.appspot.com/9303033/diff/4001/dart/compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java File dart/compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java (right): https://chromiumcodereview.appspot.com/9303033/diff/4001/dart/compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java#newcode224 dart/compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java:224: if (checkString(lhs, lhsType) && checkString(rhs, rhsType)) { On 2012/01/31 ...

8 years, 10 months ago (2012-01-31 13:21:37 UTC) #5

+zundel

Expand Messages | Collapse Messages