Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 9303019: Prevent browser windows from staying open. (Closed)

Created:
8 years, 10 months ago by Emily Fortuna
Modified:
8 years, 10 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Prevent browser windows from staying open. Committed: https://code.google.com/p/dart/source/detail?r=3705

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
M tests/isolate/isolate.status View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/language.status View 1 chunk +13 lines, -0 lines 0 comments Download
M tools/testing/run_selenium.py View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Emily Fortuna
I realized by increasing the timeout in run_selenium.py in my last CL test.dart doesn't close ...
8 years, 10 months ago (2012-01-31 01:34:24 UTC) #1
Siggi Cherem (dart-lang)
lgtm
8 years, 10 months ago (2012-01-31 01:41:02 UTC) #2
Siggi Cherem (dart-lang)
8 years, 10 months ago (2012-01-31 01:41:03 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698