Issue 9303011: Implement WebKit IDL 'module' feature [Supplemental=Foo]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9303011: Implement WebKit IDL 'module' feature [Supplemental=Foo] (Closed)

Created:
8 years, 10 months ago by sra1

Modified:
8 years, 10 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Implement WebKit IDL 'module' feature [Supplemental=Foo] interface [Supplemental=DOMWindow] DOMWindowWebAudio { ... } defines the members of DOMWindow that come from the WebAudio module. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=3701

Patch Set 1 #

Patch Set 2 : manual fix #

Patch Set 3 : manual fix #

Total comments: 1

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -13 lines)			Patch
M	client/dom/frog/dom_frog.dart	View	1 2	2 chunks	+4 lines, -0 lines	0 comments	Download
M	client/dom/generated/src/frog/DOMWindow.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	client/dom/generated/src/interface/DOMWindow.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	client/dom/generated/src/wrapping/_DOMWindowWrappingImplementation.dart	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	client/dom/generated/wrapping_dom.js	View		1 chunk	+16 lines, -0 lines	0 comments	Download
M	client/dom/generated/wrapping_dom_externs.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	client/dom/scripts/databasebuilder.py	View		2 chunks	+30 lines, -12 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

vsm

8 years, 10 months ago (2012-01-31 00:12:53 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/9303011/diff/1008/client/dom/scripts/d...
File client/dom/scripts/databasebuilder.py (right):

https://chromiumcodereview.appspot.com/9303011/diff/1008/client/dom/scripts/d...
client/dom/scripts/databasebuilder.py:164: for type_valued_attribute_name in
['Supplemental']:
Do you expect any more attrs in this list?

Expand Messages | Collapse Messages