Issue 9302034: Make test.dart use the path of the running script to find the Dart checkout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9302034: Make test.dart use the path of the running script to find the Dart checkout. (Closed)

Created:
8 years, 10 months ago by Bill Hesse

Modified:
8 years, 10 months ago

Reviewers:
Anton Muhin, Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make test.dart use the path of the running script to find the Dart checkout. This could be tools/test.dart, tools/test-runtime.dart, or tools/test-compiler.dart. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=3782

Patch Set 1 #

Total comments: 2

Patch Set 2 : Make test.dart work when run from any directory (after building). #

Patch Set 3 : Fix copyright dates. #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -29 lines)			Patch
	M	tools/testing/dart/status_file_parser.dart	View	1 2	3 chunks	+2 lines, -11 lines	0 comments	Download
	M	tools/testing/dart/test_suite.dart	View	1 2	7 chunks	+11 lines, -18 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

I guess I could leave the check in, that test_suite.dart can be found in the ...

8 years, 10 months ago (2012-01-31 16:12:54 UTC) #1

antonm

LGTM https://chromiumcodereview.appspot.com/9302034/diff/1/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): https://chromiumcodereview.appspot.com/9302034/diff/1/tools/testing/dart/test_suite.dart#newcode991 tools/testing/dart/test_suite.dart:991: Directory dart; do you need this line at ...

8 years, 10 months ago (2012-01-31 16:21:38 UTC) #2

Bill Hesse

https://chromiumcodereview.appspot.com/9302034/diff/1/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): https://chromiumcodereview.appspot.com/9302034/diff/1/tools/testing/dart/test_suite.dart#newcode991 tools/testing/dart/test_suite.dart:991: Directory dart; no. On 2012/01/31 16:21:38, antonm wrote: > ...

8 years, 10 months ago (2012-02-01 11:48:34 UTC) #3

LGTM!

Expand Messages | Collapse Messages