Issue 9302012: Better way to fix console.log in IE.

Issue 9302012: Better way to fix console.log in IE. (Closed)

Created:
8 years, 10 months ago by Emily Fortuna

Modified:
8 years, 10 months ago

Reviewers:
Siggi Cherem (dart-lang), kasperl, Jennifer Messerly

CC:
reviews_dartlang.org, kasperl

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Changing to recommended way to fix console.log in IE by Kasper. Plus some updates to the test.stats files for IE results. Committed: https://code.google.com/p/dart/source/detail?r=3704

Patch Set 4 : '' #

Total comments: 1

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -15 lines)			Patch
M	client/tests/client/client.status	View	1 2 3	1 chunk	+8 lines, -2 lines	0 comments	Download
M	client/tests/client/samples/smoketest/dartWebBase_tests.dart	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	frog/lib/corelib.dart	View	1 2 3	1 chunk	+1 line, -1 line	1 comment	Download
M	tests/corelib/corelib.status	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/isolate/isolate.status	View	1 2 3	1 chunk	+5 lines, -3 lines	0 comments	Download
M	tests/language/language.status	View	1 2 3	3 chunks	+12 lines, -2 lines	0 comments	Download
M	tools/testing/dart/test_suite.dart	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	tools/testing/run_selenium.py	View	1 2 3	3 chunks	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

lgtm https://chromiumcodereview.appspot.com/9302012/diff/4001/tools/testing/run_selenium.py File tools/testing/run_selenium.py (right): https://chromiumcodereview.appspot.com/9302012/diff/4001/tools/testing/run_selenium.py#newcode145 tools/testing/run_selenium.py:145: # the text "PASS." The test could be ...

8 years, 10 months ago (2012-01-31 00:12:54 UTC) #3

kasperl

8 years, 10 months ago (2012-01-31 05:48:42 UTC) #4

Thanks for working on this, Emily!

https://chromiumcodereview.appspot.com/9302012/diff/3004/frog/lib/corelib.dart
File frog/lib/corelib.dart (right):

https://chromiumcodereview.appspot.com/9302012/diff/3004/frog/lib/corelib.dar...
frog/lib/corelib.dart:62: } else if (typeof write === 'function') {
This looks good, but you need to remove the IE patch from frog/corejs.dart and
make sure it still works in IE and on top of d8.

Expand Messages | Collapse Messages