Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 9298048: A test of super constructor calls. (Closed)

Created:
8 years, 10 months ago by ahe
Modified:
8 years, 10 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org, hausner
Visibility:
Public.

Description

A test of super constructor calls. Committed: https://code.google.com/p/dart/source/detail?r=3681

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -0 lines) Patch
M dart/tests/language/language.status View 1 chunk +1 line, -0 lines 0 comments Download
M dart/tests/language/language-leg.status View 1 chunk +1 line, -0 lines 0 comments Download
A dart/tests/language/src/SuperFirstConstructorTest.dart View 1 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ahe
8 years, 10 months ago (2012-01-29 14:14:35 UTC) #1
kasperl
LGTM. https://chromiumcodereview.appspot.com/9298048/diff/1/dart/tests/language/src/SuperFirstConstructorTest.dart File dart/tests/language/src/SuperFirstConstructorTest.dart (right): https://chromiumcodereview.appspot.com/9298048/diff/1/dart/tests/language/src/SuperFirstConstructorTest.dart#newcode8 dart/tests/language/src/SuperFirstConstructorTest.dart:8: final argument; Why is this so complicated with ...
8 years, 10 months ago (2012-01-30 06:06:22 UTC) #2
ahe
8 years, 10 months ago (2012-01-30 07:04:10 UTC) #3
Hi Kasper,

Thank you for taking a look.

Cheers,
Peter

https://chromiumcodereview.appspot.com/9298048/diff/1/dart/tests/language/src...
File dart/tests/language/src/SuperFirstConstructorTest.dart (right):

https://chromiumcodereview.appspot.com/9298048/diff/1/dart/tests/language/src...
dart/tests/language/src/SuperFirstConstructorTest.dart:8: final argument;
On 2012/01/30 06:06:22, kasperl wrote:
> Why is this so complicated with all redirection and the named argument and the
> blah and everything? Is it a regression test for a specific issue? Could it be
> simplified? If not, maybe adding a comment that explains why it needs to
written
> this way would be useful.

This tests a specific issue in the VM. I have added some comments, and renamed
some variables, but the complexity is the same. I don't know why this bug is
triggered.

Powered by Google App Engine
This is Rietveld 408576698