Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 9297026: Use inlined double temporary object for unary operation, add tests. Fix disassembler crash. (Closed)

Created:
8 years, 11 months ago by srdjan
Modified:
8 years, 11 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Use inlined double temporary object for unary operation, add tests. Fix disassembler crash. Committed: https://code.google.com/p/dart/source/detail?r=3666

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -41 lines) Patch
M runtime/vm/compiler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/opt_code_generator_ia32.cc View 1 4 chunks +34 lines, -40 lines 0 comments Download
M tests/standalone/src/DeoptimizationTest.dart View 2 chunks +12 lines, -0 lines 0 comments Download
A tests/standalone/src/DoubleTempTest.dart View 1 2 3 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
srdjan
8 years, 11 months ago (2012-01-27 19:57:56 UTC) #1
hausner
8 years, 11 months ago (2012-01-27 21:02:19 UTC) #2
lgtm, ship it!

Powered by Google App Engine
This is Rietveld 408576698