Issue 9293006: Refactoring of string literals. Implement static string addition.

Issue 9293006: Refactoring of string literals. Implement static string addition. (Closed)

Created:
8 years, 10 months ago by Lasse Reichstein Nielsen

Modified:
8 years, 10 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Refactoring of string literals. Implement static string addition. QuotedString has become DartString, and it represents the actual Dart string value (i.e., iterating over it provides character codes after interpreting escape sequences). Quoting is now only used during parsing, after that a DartString is just its content. Static string addition (both as optimization and as required for compile time constant expressions) is implemented by creating a ConsDartString object that represents the concatenation, without flattening the string unnecessarily. Committed: https://code.google.com/p/dart/source/detail?r=3709

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address review comments. #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+239 lines, -129 lines)			Patch
M	frog/leg/scanner/listener.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	frog/leg/ssa/builder.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	frog/leg/ssa/codegen.dart	View		3 chunks	+30 lines, -74 lines	0 comments	Download
M	frog/leg/ssa/nodes.dart	View		4 chunks	+80 lines, -2 lines	0 comments	Download
M	frog/leg/ssa/optimize.dart	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	frog/leg/string_validator.dart	View		4 chunks	+16 lines, -10 lines	0 comments	Download
M	frog/leg/tree/nodes.dart	View	1	1 chunk	+101 lines, -32 lines	0 comments	Download
M	frog/leg/util/characters.dart	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	frog/tests/leg/src/BuiltinInterceptorTest.dart	View	1	1 chunk	+2 lines, -4 lines	0 comments	Download
M	frog/tests/leg/src/ConstantFoldingTest.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://chromiumcodereview.appspot.com/9293006/diff/1/frog/leg/tree/nodes.dart File frog/leg/tree/nodes.dart (right): https://chromiumcodereview.appspot.com/9293006/diff/1/frog/leg/tree/nodes.dart#newcode721 frog/leg/tree/nodes.dart:721: * strig with escapes. string https://chromiumcodereview.appspot.com/9293006/diff/1/frog/tests/leg/src/BuiltinInterceptorTest.dart File frog/tests/leg/src/BuiltinInterceptorTest.dart ...

8 years, 10 months ago (2012-01-30 16:06:56 UTC) #2

Lasse Reichstein Nielsen

8 years, 10 months ago (2012-01-31 06:46:15 UTC) #3

https://chromiumcodereview.appspot.com/9293006/diff/1/frog/leg/tree/nodes.dart
File frog/leg/tree/nodes.dart (right):

https://chromiumcodereview.appspot.com/9293006/diff/1/frog/leg/tree/nodes.dar...
frog/leg/tree/nodes.dart:721: * strig with escapes.
On 2012/01/30 16:06:56, floitsch wrote:
> string

Done.

https://chromiumcodereview.appspot.com/9293006/diff/1/frog/tests/leg/src/Buil...
File frog/tests/leg/src/BuiltinInterceptorTest.dart (right):

https://chromiumcodereview.appspot.com/9293006/diff/1/frog/tests/leg/src/Buil...
frog/tests/leg/src/BuiltinInterceptorTest.dart:29: // TODO(lrn): Switch these
two to isTrue when we support constant folding
On 2012/01/30 16:06:56, floitsch wrote:
> remove TODO.

Done.

Expand Messages | Collapse Messages