Issue 9290007: Fixes isolate issue #1329

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9290007: Fixes isolate issue #1329 (Closed)

Created:
8 years, 11 months ago by jimhug

Modified:
8 years, 11 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org, vsm, sra1, Siggi Cherem (dart-lang)

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixes isolate issue #1329 Committed: https://code.google.com/p/dart/source/detail?r=3589

Patch Set 1 #

Patch Set 2 : merged #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -1 line)			Patch
M	client/tests/client/client.status	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	frog/member_set.dart	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	frog/minfrog	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jimhug

This fixes the test that I broke on Monday. Thanks to Vijay for checking that ...

8 years, 11 months ago (2012-01-25 02:48:19 UTC) #1

Jennifer Messerly

8 years, 11 months ago (2012-01-25 03:23:22 UTC) #2

lgtm.

Yeah, it'd be awesome if event handlers could close over their isolate state
somehow. Or we don't have multiple isolates talking to the DOM (which I'm not
convinced makes sense).

Expand Messages | Collapse Messages