Issue 9289042: Minor changes to the dart:io library files.

Issue 9289042: Minor changes to the dart:io library files. (Closed)

Created:
8 years, 11 months ago by Mads Ager (google)

Modified:
8 years, 11 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Minor changes to the dart:io library files. - Split some of the streams into an interface and an implementation file. - Add documentation comments where missing. R=sgjesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=3616

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add missing files. #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+254 lines, -436 lines)			Patch
M	editor/tools/features/com.google.dart.tools.deploy.feature_releng/build_rcp.xml	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	runtime/bin/directory.dart	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	runtime/bin/eventhandler.dart	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/bin/file.dart	View	1	5 chunks	+96 lines, -6 lines	0 comments	Download
M	runtime/bin/file_impl.dart	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/bin/input_stream.dart	View		2 chunks	+4 lines, -5 lines	0 comments	Download
M	runtime/bin/io_sources.gypi	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	runtime/bin/list_stream.dart	View		1 chunk	+42 lines, -154 lines	0 comments	Download
A +	runtime/bin/list_stream_impl.dart	View	1	4 chunks	+14 lines, -45 lines	0 comments	Download
M	runtime/bin/process.dart	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	runtime/bin/socket_impl.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/bin/socket_stream.dart	View		1 chunk	+19 lines, -182 lines	0 comments	Download
A +	runtime/bin/socket_stream_impl.dart	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/bin/timer_impl.dart	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	tests/standalone/src/ChunkedStreamTest.dart	View		3 chunks	+6 lines, -4 lines	0 comments	Download
M	tests/standalone/src/ListInputStreamTest.dart	View		12 chunks	+29 lines, -13 lines	0 comments	Download
M	tests/standalone/src/StringStreamTest.dart	View		6 chunks	+12 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

Missing new files: list_stream_impl.dart socket_stream_impl.dart https://chromiumcodereview.appspot.com/9289042/diff/1/runtime/bin/file.dart File runtime/bin/file.dart (right): https://chromiumcodereview.appspot.com/9289042/diff/1/runtime/bin/file.dart#newcode22 runtime/bin/file.dart:22: * streams using [openInputStream] ...

8 years, 11 months ago (2012-01-26 09:50:17 UTC) #2

Mads Ager (google)

Whoops. Added missing files. https://chromiumcodereview.appspot.com/9289042/diff/1/runtime/bin/file.dart File runtime/bin/file.dart (right): https://chromiumcodereview.appspot.com/9289042/diff/1/runtime/bin/file.dart#newcode22 runtime/bin/file.dart:22: * streams using [openInputStream] and ...

8 years, 11 months ago (2012-01-26 09:55:26 UTC) #3

lgtm

Expand Messages | Collapse Messages