Issue 9288001: Don't access a message after it has been enqueued. It may be deleted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9288001: Don't access a message after it has been enqueued. It may be deleted (Closed)

Created:
8 years, 11 months ago by turnidge

Modified:
8 years, 11 months ago

Reviewers:
siva, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Don't access a message after it has been enqueued. It may be deleted at that point. Committed: https://code.google.com/p/dart/source/detail?r=3576

Patch Set 1 #

Total comments: 1

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	runtime/vm/isolate.cc	View		1 chunk	+6 lines, -2 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

8 years, 11 months ago (2012-01-26 00:01:46 UTC) #3

DBC

https://chromiumcodereview.appspot.com/9288001/diff/1/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

https://chromiumcodereview.appspot.com/9288001/diff/1/runtime/vm/isolate.cc#n...
runtime/vm/isolate.cc:108: ASSERT(priority < Message::kOOBPriority);
Shouldn't this assert be after the if check?

Expand Messages | Collapse Messages