Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 9285031: Remove support for obsolete syntax of factory methods and default classes. (Closed)

Created:
8 years, 11 months ago by regis
Modified:
8 years, 11 months ago
Reviewers:
hausner, zundel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove support for obsolete syntax of factory methods and default classes. Committed: https://code.google.com/p/dart/source/detail?r=3578

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -193 lines) Patch
M runtime/vm/class_finalizer.cc View 1 3 chunks +3 lines, -55 lines 0 comments Download
M runtime/vm/code_generator_ia32.cc View 1 2 chunks +7 lines, -13 lines 0 comments Download
M runtime/vm/code_generator_x64.cc View 1 2 chunks +7 lines, -13 lines 0 comments Download
M runtime/vm/parser.cc View 1 7 chunks +36 lines, -110 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 1 chunk +8 lines, -0 lines 0 comments Download
M tests/language/src/NonParameterizedFactory2Test.dart View 1 1 chunk +1 line, -1 line 1 comment Download
M tests/language/src/NonParameterizedFactoryTest.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
regis
8 years, 11 months ago (2012-01-24 21:55:34 UTC) #1
hausner
LGTM.
8 years, 11 months ago (2012-01-24 22:08:36 UTC) #2
zundel
https://chromiumcodereview.appspot.com/9285031/diff/6001/tests/language/src/NonParameterizedFactory2Test.dart File tests/language/src/NonParameterizedFactory2Test.dart (left): https://chromiumcodereview.appspot.com/9285031/diff/6001/tests/language/src/NonParameterizedFactory2Test.dart#oldcode5 tests/language/src/NonParameterizedFactory2Test.dart:5: interface Interface<T> default Factory { I'm not seeing a ...
8 years, 11 months ago (2012-01-24 22:52:40 UTC) #3
regis
8 years, 11 months ago (2012-01-24 23:15:52 UTC) #4
Good point. I was not aware of the fact that the list of type parameters can be
omitted in the default factory clause. I definitely remember a time where it had
to match exactly and I do not know when that changed. I'll double-check with
Gilad before allowing it again.

Thanks,
Regis

On 2012/01/24 22:52:40, zundel wrote:
>
https://chromiumcodereview.appspot.com/9285031/diff/6001/tests/language/src/N...
> File tests/language/src/NonParameterizedFactory2Test.dart (left):
> 
>
https://chromiumcodereview.appspot.com/9285031/diff/6001/tests/language/src/N...
> tests/language/src/NonParameterizedFactory2Test.dart:5: interface Interface<T>
> default Factory {
> I'm not seeing a change to the spec since I last worked on the default class
> specification, did you confirm with Gilad?
> 
> At the time,  this syntax was OK with the new 'default' syntax - in fact, this
> test is to show that you can use the non-parameterized type with a
parameterized
> default class if you like.  
> 
> 
> 
>
https://docs.google.com/a/google.com/document/pub?id=1RqcfL64kw5SJkyut6eN34d7...
> 
>   "If the default factory clause of I includes a list of type parameters tps,
> then tps must be identical to the type parameters given in the type
declaration
> of F, or a compile-time error occurs."

Powered by Google App Engine
This is Rietveld 408576698