Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 9285017: Comment and white-space cleanup in IO libraries. (Closed)

Created:
8 years, 11 months ago by Mads Ager (google)
Modified:
8 years, 11 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Comment and white-space cleanup in IO libraries. - use dart doc comment for interface comments. - use '//' style comments for non-doc comments. - remove some whitespace. R=whesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=3554

Patch Set 1 #

Patch Set 2 : More of the same. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -91 lines) Patch
M runtime/bin/eventhandler.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/file_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/output_stream.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/process_impl.dart View 2 chunks +9 lines, -9 lines 0 comments Download
M runtime/bin/socket.dart View 5 chunks +18 lines, -22 lines 0 comments Download
M runtime/bin/socket_impl.dart View 1 2 chunks +16 lines, -32 lines 0 comments Download
M runtime/bin/timer.dart View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/bin/timer_impl.dart View 5 chunks +11 lines, -23 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (google)
8 years, 11 months ago (2012-01-24 15:13:39 UTC) #1
Bill Hesse
LGTM. It seems wrong that we can't use Dartdoc on implementation files, unless we want ...
8 years, 11 months ago (2012-01-24 15:37:49 UTC) #2
Mads Ager (google)
8 years, 11 months ago (2012-01-24 15:39:02 UTC) #3
On 2012/01/24 15:37:49, Bill Hesse wrote:
> LGTM.
> 
> It seems wrong that we can't use Dartdoc on implementation files, unless we
want
> to publish the interface.  We should work on a better way of selecting what to
> publish, so we can have internal files with Dartdoc comments.

You can use DartDoc all you want in the implementation files. However, the
comments that I changed to '//' were not DartDoc comments in the first place.
They were just more verbose than they had to be. :)

Powered by Google App Engine
This is Rietveld 408576698