Issue 9283003: Don't use _toList on FrozenElementList.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9283003: Don't use _toList on FrozenElementList. (Closed)

Created:
8 years, 11 months ago by nweiz

Modified:
8 years, 11 months ago

Reviewers:
Jacob, sra1

CC:
reviews_dartlang.org, Jacob

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Don't use _toList on FrozenElementList. TBR Committed: https://code.google.com/p/dart/source/detail?r=3518

Patch Set 1 #

Total comments: 4

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -28 lines)			Patch
	M	client/html/release/htmlimpl.dart	View		1 chunk	+19 lines, -14 lines	4 comments	Download
	M	client/html/src/ElementWrappingImplementation.dart	View		1 chunk	+19 lines, -14 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jacob

I added my comments to the generated file. Sorry about that. https://chromiumcodereview.appspot.com/9283003/diff/1/client/html/release/htmlimpl.dart File client/html/release/htmlimpl.dart (right): ...

8 years, 11 months ago (2012-01-26 01:56:27 UTC) #2

nweiz

8 years, 11 months ago (2012-01-26 23:18:09 UTC) #3

https://chromiumcodereview.appspot.com/9283003/diff/1/client/html/release/htm...
File client/html/release/htmlimpl.dart (right):

https://chromiumcodereview.appspot.com/9283003/diff/1/client/html/release/htm...
client/html/release/htmlimpl.dart:22484: +    var out = [];
On 2012/01/26 01:56:27, Jacob wrote:
> var --> final here and elsewhere in this file

Done.

https://chromiumcodereview.appspot.com/9283003/diff/1/client/html/release/htm...
client/html/release/htmlimpl.dart:22492: +    var out = [];
On 2012/01/26 01:56:27, Jacob wrote:
> [] --> <Element>[]

This became an ElementList later on anyway.

Expand Messages | Collapse Messages