Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 9271036: Implement List<T> operations on dom types via manual mixins. (Closed)

Created:
8 years, 11 months ago by sra1
Modified:
8 years, 11 months ago
Reviewers:
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Implement List<T> operations on dom types via manual mixins. This gets HTMLCollectionTest.html and Typing.html from the layout tests working for Frog. I tried using a hidden native parameterized base class but that did not work, so I had to backed off to having to mix-in the List<T> methods on each native class that implements List<T>. This is what we did with dartc. The mixins are in a template - not quite as bad as in the python code but still not so easy for others to find. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=3590

Patch Set 1 #

Patch Set 2 : remove debug comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2182 lines, -53 lines) Patch
M client/dom/frog/dom_frog.dart View 1 16 chunks +1048 lines, -24 lines 0 comments Download
M client/dom/generated/src/frog/CanvasPixelArray.dart View 1 1 chunk +69 lines, -2 lines 0 comments Download
M client/dom/generated/src/frog/Float32Array.dart View 1 1 chunk +69 lines, -2 lines 0 comments Download
M client/dom/generated/src/frog/Float64Array.dart View 1 1 chunk +69 lines, -2 lines 0 comments Download
M client/dom/generated/src/frog/HTMLCollection.dart View 1 chunk +68 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/Int16Array.dart View 1 1 chunk +69 lines, -2 lines 0 comments Download
M client/dom/generated/src/frog/Int32Array.dart View 1 1 chunk +69 lines, -2 lines 0 comments Download
M client/dom/generated/src/frog/Int8Array.dart View 1 1 chunk +69 lines, -2 lines 0 comments Download
M client/dom/generated/src/frog/MediaList.dart View 1 chunk +68 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/NamedNodeMap.dart View 1 chunk +68 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/NodeList.dart View 1 chunk +68 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/StyleSheetList.dart View 1 chunk +68 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/TouchList.dart View 1 chunk +68 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/Uint16Array.dart View 1 1 chunk +69 lines, -2 lines 0 comments Download
M client/dom/generated/src/frog/Uint32Array.dart View 1 1 chunk +69 lines, -2 lines 0 comments Download
M client/dom/generated/src/frog/Uint8Array.dart View 1 1 chunk +69 lines, -2 lines 0 comments Download
M client/dom/scripts/dartgenerator.py View 1 4 chunks +19 lines, -5 lines 0 comments Download
M client/dom/src/_Lists.dart View 1 chunk +19 lines, -0 lines 0 comments Download
A client/dom/templates/dom/frog/immutable_list_mixin.darttemplate View 1 chunk +67 lines, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698