Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 9271020: Include subtype information in generated docs. (Closed)

Created:
8 years, 11 months ago by Bob Nystrom
Modified:
8 years, 10 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Include subtype information in generated docs. With this change, dartdoc does a more comprehensive job of letting users navigate the web of types. For each class, this will show its chain of superclasses, interfaces it implements, and its immediate subclasses. For interfaces, it shows superinterfaces, subinterfaces, implementing classes, and a default class if it has one. Committed: https://code.google.com/p/dart/source/detail?r=3515

Patch Set 1 #

Total comments: 4

Patch Set 2 : Respond to review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -45 lines) Patch
M utils/dartdoc/client-live-nav.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/dartdoc/dartdoc.dart View 1 5 chunks +129 lines, -37 lines 0 comments Download
M utils/dartdoc/static/styles.css View 4 chunks +32 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Bob Nystrom
To see it in action, I put some generated docs up at: http://stuffwithstuff.com/temp/docs A few ...
8 years, 11 months ago (2012-01-20 22:46:49 UTC) #1
nweiz
lgtm https://chromiumcodereview.appspot.com/9271020/diff/1/utils/dartdoc/dartdoc.dart File utils/dartdoc/dartdoc.dart (right): https://chromiumcodereview.appspot.com/9271020/diff/1/utils/dartdoc/dartdoc.dart#newcode541 utils/dartdoc/dartdoc.dart:541: if (type.name.startsWith('_')) continue; You already filtered for this.
8 years, 11 months ago (2012-01-21 01:11:15 UTC) #2
Siggi Cherem (dart-lang)
lgtm I especially like how the superclasses chain looks. https://chromiumcodereview.appspot.com/9271020/diff/1/utils/dartdoc/dartdoc.dart File utils/dartdoc/dartdoc.dart (right): https://chromiumcodereview.appspot.com/9271020/diff/1/utils/dartdoc/dartdoc.dart#newcode574 utils/dartdoc/dartdoc.dart:574: ...
8 years, 11 months ago (2012-01-21 01:57:25 UTC) #3
Bob Nystrom
8 years, 10 months ago (2012-02-01 21:41:56 UTC) #4
Heh, never sent these...

https://chromiumcodereview.appspot.com/9271020/diff/1/utils/dartdoc/dartdoc.dart
File utils/dartdoc/dartdoc.dart (right):

https://chromiumcodereview.appspot.com/9271020/diff/1/utils/dartdoc/dartdoc.d...
utils/dartdoc/dartdoc.dart:541: if (type.name.startsWith('_')) continue;
On 2012/01/21 01:11:15, nweiz wrote:
> You already filtered for this.

Done.

https://chromiumcodereview.appspot.com/9271020/diff/1/utils/dartdoc/dartdoc.d...
utils/dartdoc/dartdoc.dart:574: listTypes(type.subtypes, 'Subclasses');
On 2012/01/21 01:57:25, sigmund wrote:
> it would be nice to sort these by name

Done.

Powered by Google App Engine
This is Rietveld 408576698