Issue 9270048: Lots of frog cleanup

Issue 9270048: Lots of frog cleanup (Closed)

Created:
8 years, 11 months ago by jimhug

Modified:
8 years, 11 months ago

Reviewers:
sra1, Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Lots of frog cleanup Committed: https://code.google.com/p/dart/source/detail?r=3504

Patch Set 1 #

Total comments: 2

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4845 lines, -4302 lines)			Patch
M	client/tests/client/client.status	View	1 chunk	+0 lines, -3 lines	0 comments	Download
A	frog/analyze.dart	View	1 chunk	+748 lines, -0 lines	0 comments	Download
A	frog/analyze_frame.dart	View	1 chunk	+169 lines, -0 lines	0 comments	Download
M	frog/block_scope.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	frog/element.dart	View	4 chunks	+39 lines, -23 lines	0 comments	Download
M	frog/gen.dart	View	39 chunks	+106 lines, -113 lines	2 comments	Download
M	frog/lang.dart	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	frog/lib/corelib_impl.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	frog/lib/num.dart	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	frog/lib/string_base.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	frog/library.dart	View	4 chunks	+12 lines, -11 lines	0 comments	Download
M	frog/member.dart	View	34 chunks	+197 lines, -540 lines	0 comments	Download
A	frog/member_set.dart	View	1 chunk	+283 lines, -0 lines	0 comments	Download
A	frog/method_data.dart	View	1 chunk	+151 lines, -0 lines	0 comments	Download
M	frog/minfrog	View	431 chunks	+2688 lines, -3221 lines	0 comments	Download
M	frog/parser.dart	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	frog/scripts/tree_gen.py	View	3 chunks	+2 lines, -4 lines	0 comments	Download
M	frog/tests/frog/frog.status	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	frog/tree.dart	View	2 chunks	+3 lines, -7 lines	0 comments	Download
M	frog/tree.g.dart	View	5 chunks	+14 lines, -6 lines	0 comments	Download
M	frog/type.dart	View	29 chunks	+161 lines, -270 lines	0 comments	Download
M	frog/utils.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	frog/value.dart	View	40 chunks	+221 lines, -77 lines	0 comments	Download
M	frog/var_member.dart	View	5 chunks	+11 lines, -9 lines	0 comments	Download
M	frog/world.dart	View	2 chunks	+12 lines, -1 line	0 comments	Download
M	tests/language/language.status	View	3 chunks	+1 line, -3 lines	0 comments	Download
M	tests/language/src/NewExpressionTypeArgsFrogTest.dart	View	1 chunk	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jimhug

TBR - Looking forward to seeing CLs that fix my TODOs <smile>

8 years, 11 months ago (2012-01-23 18:19:46 UTC) #1

sra1

8 years, 11 months ago (2012-01-23 20:40:30 UTC) #2

https://chromiumcodereview.appspot.com/9270048/diff/1/frog/gen.dart
File frog/gen.dart (right):

https://chromiumcodereview.appspot.com/9270048/diff/1/frog/gen.dart#newcode348
frog/gen.dart:348: writer.writeln('var ${type.jsname} = {};');
This code is being emitted unnecessarily for all 500 DOM types - see
_typeNeedsHolderForStaticMethods.

https://chromiumcodereview.appspot.com/9270048/diff/1/frog/gen.dart#newcode479
frog/gen.dart:479: return type.isUsed;
This new code causes 500 useless dummy declarations for DOM hidden native
classes with no static methods, i.e. 20k bloat.

Expand Messages | Collapse Messages