- Fix the return type of File.openSync.

- Fix the return type of File.openSync.
- Ensure to always hand a ObjectArray to the native code.
- Start making private methods private.
Committed: https://code.google.com/p/dart/source/detail?r=3424

[Ivan Posva, 2012-01-19 02:39:15]

This cuts the time to write a 4MB from 20 seconds down to 99 ms. Please use the
same pattern to address other write-like operations in the IO library.

Thanks,
-Ivan

[siva, 2012-01-19 02:44:32]

lgtm

[Mads Ager (google), 2012-01-19 07:13:27]

LGTM except for the single inconsistent underscore.

http://codereview.chromium.org/9264001/diff/1/runtime/bin/file_impl.dart
File runtime/bin/file_impl.dart (right):

http://codereview.chromium.org/9264001/diff/1/runtime/bin/file_impl.dart#newc...
runtime/bin/file_impl.dart:423: static int _writeList(int id, List<int> buffer,
int offset, int bytes) {
You can't get to this member in any case from the outside because it is a static
member in a private class. You should not be able to get to _FileUtils and
therefore you should not be able to call this.

I used to have underscores on all of these but I'm not sure it adds much? If we
want underscores could we please add them to all the members here?

[Ivan Posva, 2012-01-20 21:55:06]

http://codereview.chromium.org/9264001/diff/1/runtime/bin/file_impl.dart
File runtime/bin/file_impl.dart (right):

http://codereview.chromium.org/9264001/diff/1/runtime/bin/file_impl.dart#newc...
runtime/bin/file_impl.dart:423: static int _writeList(int id, List<int> buffer,
int offset, int bytes) {
On 2012/01/19 07:13:27, Mads Ager wrote:
> You can't get to this member in any case from the outside because it is a
static
> member in a private class. You should not be able to get to _FileUtils and
> therefore you should not be able to call this.
> 
> I used to have underscores on all of these but I'm not sure it adds much? If
we
> want underscores could we please add them to all the members here?

The thing is that if somebody decides to make FileUtils a public class you need
to change all currently exported names to private. But we can fix this in
another cleanup round. Changing this example back to the way it was.