Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 9255025: Revert the revert of http://code.google.com/p/dart/source/detail?r=3360. (Closed)

Created:
8 years, 11 months ago by mmendez
Modified:
8 years, 11 months ago
Reviewers:
floitsch, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert the revert of http://code.google.com/p/dart/source/detail?r=3360. Kasper found and fixed the underlying native class code generation bug as part of http://code.google.com/p/dart/source/detail?r=3390. TBR=kasperl,floitsch Committed: https://code.google.com/p/dart/source/detail?r=3412

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -24 lines) Patch
M compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java View 2 chunks +12 lines, -0 lines 0 comments Download
M compiler/lib/corelib_impl.dart View 1 chunk +0 lines, -1 line 0 comments Download
M compiler/lib/implementation/array.dart View 2 chunks +4 lines, -6 lines 0 comments Download
M compiler/lib/implementation/array.js View 1 chunk +0 lines, -6 lines 0 comments Download
D compiler/lib/implementation/type_token.dart View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
mmendez
8 years, 11 months ago (2012-01-18 20:07:35 UTC) #1
kasperl
8 years, 11 months ago (2012-01-19 06:56:00 UTC) #2
LGTM! Thanks, Miguel.

Powered by Google App Engine
This is Rietveld 408576698