Split dart:builtin into dart:builtin and dart:io.

Split dart:builtin into dart:builtin and dart:io.

- dart:builtin is implicitly imported.
- dart:io has to be explicitly imported.

I will update the macos and windows stable test binaries when we
are happy with the solution.

R=iposva@google.com
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=3537

[Mads Ager (google), 2012-01-19 13:49:18]

Only the changes in runtime/bin are interesting. The rest is just adding
#import('dart:io') in all the places I could find that needed it.

[Ivan Posva, 2012-01-21 20:24:55]

First round of comments.

-Ivan

http://codereview.chromium.org/9254026/diff/1/runtime/bin/buffer_list.dart
File runtime/bin/buffer_list.dart (right):

http://codereview.chromium.org/9254026/diff/1/runtime/bin/buffer_list.dart#ne...
runtime/bin/buffer_list.dart:5: #library("io");
It would be nice to pull this out into its own file and make sure it is listed
first in the gypi, with an appropriate comment.

Also this library makes use of "dart:nativewrappers" and "dart:coreimpl", so
that should be properly imported here. See builtin.dart for example.

http://codereview.chromium.org/9254026/diff/1/runtime/bin/builtin.cc
File runtime/bin/builtin.cc (right):

http://codereview.chromium.org/9254026/diff/1/runtime/bin/builtin.cc#newcode60
runtime/bin/builtin.cc:60: case kCoreImplLibrary:
Why are the native wrappers and the coreimpl library handled here? They should
be handled directly by the VM. If this is indeed needed here, we have to
reevaluate how the standalone binary is loading the builtin libraries.

http://codereview.chromium.org/9254026/diff/1/runtime/bin/builtin.h
File runtime/bin/builtin.h (right):

http://codereview.chromium.org/9254026/diff/1/runtime/bin/builtin.h#newcode28
runtime/bin/builtin.h:28: kNativeWrappersLibrary
ditto. Only the builtin and the io library should be handled here.

http://codereview.chromium.org/9254026/diff/1/runtime/bin/gen_snapshot.cc
File runtime/bin/gen_snapshot.cc (right):

http://codereview.chromium.org/9254026/diff/1/runtime/bin/gen_snapshot.cc#new...
runtime/bin/gen_snapshot.cc:192: // Load the dart:io library with dependencies
as a library to make
ASSERT(id == Builtin::kIOLibrary);

[Mads Ager (google), 2012-01-23 11:35:38]

Thanks Ivan! New version uploaded that loads the dart:io library in the tag
handler when running without snapshots.

http://codereview.chromium.org/9254026/diff/1/runtime/bin/buffer_list.dart
File runtime/bin/buffer_list.dart (right):

http://codereview.chromium.org/9254026/diff/1/runtime/bin/buffer_list.dart#ne...
runtime/bin/buffer_list.dart:5: #library("io");
On 2012/01/21 20:24:55, Ivan Posva wrote:
> It would be nice to pull this out into its own file and make sure it is listed
> first in the gypi, with an appropriate comment.
> 
> Also this library makes use of "dart:nativewrappers" and "dart:coreimpl", so
> that should be properly imported here. See builtin.dart for example.

Restored the imports of coreimpl and nativewrappers. Extracted a io.dart file
which needs to be listed first in the gypi. Thanks!

http://codereview.chromium.org/9254026/diff/1/runtime/bin/builtin.cc
File runtime/bin/builtin.cc (right):

http://codereview.chromium.org/9254026/diff/1/runtime/bin/builtin.cc#newcode60
runtime/bin/builtin.cc:60: case kCoreImplLibrary:
On 2012/01/21 20:24:55, Ivan Posva wrote:
> Why are the native wrappers and the coreimpl library handled here? They should
> be handled directly by the VM. If this is indeed needed here, we have to
> reevaluate how the standalone binary is loading the builtin libraries.

You are absolutely right. Thanks.

This was a result of me not having wrapped my head completely around the
structure. I ran into issues when handling dart:io in the tag handled. I have
resolved those issues and deal only with builtin and io here.

http://codereview.chromium.org/9254026/diff/1/runtime/bin/builtin.h
File runtime/bin/builtin.h (right):

http://codereview.chromium.org/9254026/diff/1/runtime/bin/builtin.h#newcode28
runtime/bin/builtin.h:28: kNativeWrappersLibrary
On 2012/01/21 20:24:55, Ivan Posva wrote:
> ditto. Only the builtin and the io library should be handled here.

Done.

http://codereview.chromium.org/9254026/diff/1/runtime/bin/gen_snapshot.cc
File runtime/bin/gen_snapshot.cc (right):

http://codereview.chromium.org/9254026/diff/1/runtime/bin/gen_snapshot.cc#new...
runtime/bin/gen_snapshot.cc:192: // Load the dart:io library with dependencies
as a library to make
On 2012/01/21 20:24:55, Ivan Posva wrote:
> ASSERT(id == Builtin::kIOLibrary);

Done.

http://codereview.chromium.org/9254026/diff/7152/runtime/vm/parser.cc
File runtime/vm/parser.cc (left):

http://codereview.chromium.org/9254026/diff/7152/runtime/vm/parser.cc#oldcode...
runtime/vm/parser.cc:3334: library.Register();
I changed the handling of this. Registering an empty library here means that you
cannot do a 'already loaded' check in the tag handler by checking if
Dart_LookupLibrary finds something. Also, creating a new library here as well as
in Dart_LoadLibrary(url, source) seemed unnecessary?

[Ivan Posva, 2012-01-24 02:17:30]

LGTM -ip

http://codereview.chromium.org/9254026/diff/12001/tests/standalone/src/Socket...
File tests/standalone/src/SocketStreamCloseTest.dart (left):

http://codereview.chromium.org/9254026/diff/12001/tests/standalone/src/Socket...
tests/standalone/src/SocketStreamCloseTest.dart:11: 
?

[Mads Ager (google), 2012-01-24 07:47:19]

http://codereview.chromium.org/9254026/diff/12001/tests/standalone/src/Socket...
File tests/standalone/src/SocketStreamCloseTest.dart (left):

http://codereview.chromium.org/9254026/diff/12001/tests/standalone/src/Socket...
tests/standalone/src/SocketStreamCloseTest.dart:11: 
On 2012/01/24 02:17:30, Ivan Posva wrote:
> ?

Reverted edit. Thanks.

[siva, 2012-02-07 02:51:12]

One top level question, one of the goals for splitting the dart:builtin into
dart:io and dart:builtin was to load the io stuff only if needed i.e when
somebody imports "dart:io".

The generic snapshot creator (i.e the base guy which has all the corelibs etc.)
however seems to also include dart:io in it. This means standalone dart has the
library dart:io always loaded in it.

Is this how we want it set up, the library is always loaded but visible only to
those that explicitly import it using import "dart:io"