Issue 9254022: Make sure to use an ObjectArray when writing to a socket

Issue 9254022: Make sure to use an ObjectArray when writing to a socket (Closed)

Created:
8 years, 11 months ago by Søren Gjesse

Modified:
8 years, 11 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make sure to use an ObjectArray when writing to a socket This improves performance of the native code accessing the data in the supplied buffer when it is no already an ObjectArray. The code is duplicated as refactoring into a separate function was not feasible. R=ager@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=3428

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed review comments from ager@ #

Patch Set 3 : Really address the review comments from ager@ #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -14 lines)			Patch
	M	runtime/bin/file_impl.dart	View	1 2	4 chunks	+15 lines, -12 lines	0 comments	Download
	M	runtime/bin/socket_impl.dart	View	1 2	2 chunks	+18 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

lgtm https://chromiumcodereview.appspot.com/9254022/diff/1/runtime/bin/file_impl.dart File runtime/bin/file_impl.dart (right): https://chromiumcodereview.appspot.com/9254022/diff/1/runtime/bin/file_impl.dart#newcode425 runtime/bin/file_impl.dart:425: // currently much faster. This function will make ...

8 years, 11 months ago (2012-01-19 08:38:25 UTC) #2

Søren Gjesse

8 years, 11 months ago (2012-01-19 08:45:14 UTC) #3

https://chromiumcodereview.appspot.com/9254022/diff/1/runtime/bin/file_impl.dart
File runtime/bin/file_impl.dart (right):

https://chromiumcodereview.appspot.com/9254022/diff/1/runtime/bin/file_impl.d...
runtime/bin/file_impl.dart:425: // currently much faster. This function will
make a *copy* of
On 2012/01/19 08:38:25, Mads Ager wrote:
> Remove the stars? :)

Done.

https://chromiumcodereview.appspot.com/9254022/diff/1/runtime/bin/socket_impl...
File runtime/bin/socket_impl.dart (right):

https://chromiumcodereview.appspot.com/9254022/diff/1/runtime/bin/socket_impl...
runtime/bin/socket_impl.dart:330: // When using the Dart C API access to
ObjectArray by index is
On 2012/01/19 08:38:25, Mads Ager wrote:
> Please move the comment to the same place as in the other file so the pattern
is
> easier to recognize.

Done.

Expand Messages | Collapse Messages