Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9252002: Make changes for Safari to run with webdriver on the bots. (Closed)

Created:
8 years, 11 months ago by Emily Fortuna
Modified:
8 years, 11 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make changes for Safari to run with webdriver on the bots. Committed: https://code.google.com/p/dart/source/detail?r=3382

Patch Set 1 : '' #

Total comments: 13

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -17 lines) Patch
M client/tests/client/client.status View 2 chunks +5 lines, -2 lines 0 comments Download
M tests/corelib/corelib.status View 2 chunks +4 lines, -1 line 0 comments Download
M tests/isolate/isolate.status View 1 chunk +6 lines, -0 lines 0 comments Download
M tests/language/language.status View 2 chunks +19 lines, -5 lines 0 comments Download
M tools/testing/perf_testing/create_graph.py View 1 1 chunk +1 line, -3 lines 0 comments Download
M tools/testing/perf_testing/perf_README.txt View 1 1 chunk +10 lines, -6 lines 0 comments Download
M tools/testing/run_selenium.py View 1 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Emily Fortuna
https://chromiumcodereview.appspot.com/9252002/diff/2001/tools/testing/perf_testing/perf_README.txt File tools/testing/perf_testing/perf_README.txt (right): https://chromiumcodereview.appspot.com/9252002/diff/2001/tools/testing/perf_testing/perf_README.txt#newcode94 tools/testing/perf_testing/perf_README.txt:94: b) copy the file in /Library/Preferences/com.apple.Safari.plist to $DARTDIR/tools/testing/com.apple.Safari.plist Yes, ...
8 years, 11 months ago (2012-01-18 01:12:37 UTC) #1
Siggi Cherem (dart-lang)
lgtm https://chromiumcodereview.appspot.com/9252002/diff/2001/tools/testing/perf_testing/create_graph.py File tools/testing/perf_testing/create_graph.py (right): https://chromiumcodereview.appspot.com/9252002/diff/2001/tools/testing/perf_testing/create_graph.py#newcode514 tools/testing/perf_testing/create_graph.py:514: #TODO(efortuna): Ensure that the frog and froglib flags ...
8 years, 11 months ago (2012-01-18 01:35:16 UTC) #2
Jennifer Messerly
lgtm https://chromiumcodereview.appspot.com/9252002/diff/2001/tests/language/language.status File tests/language/language.status (right): https://chromiumcodereview.appspot.com/9252002/diff/2001/tests/language/language.status#newcode321 tests/language/language.status:321: [ $component == webdriver && $browser == safari ...
8 years, 11 months ago (2012-01-18 01:35:51 UTC) #3
Emily Fortuna
https://chromiumcodereview.appspot.com/9252002/diff/2001/tests/language/language.status File tests/language/language.status (right): https://chromiumcodereview.appspot.com/9252002/diff/2001/tests/language/language.status#newcode321 tests/language/language.status:321: [ $component == webdriver && $browser == safari ] ...
8 years, 11 months ago (2012-01-18 02:20:36 UTC) #4
Siggi Cherem (dart-lang)
https://chromiumcodereview.appspot.com/9252002/diff/2001/tools/testing/perf_testing/perf_README.txt File tools/testing/perf_testing/perf_README.txt (right): https://chromiumcodereview.appspot.com/9252002/diff/2001/tools/testing/perf_testing/perf_README.txt#newcode94 tools/testing/perf_testing/perf_README.txt:94: b) copy the file in /Library/Preferences/com.apple.Safari.plist to $DARTDIR/tools/testing/com.apple.Safari.plist On ...
8 years, 11 months ago (2012-01-18 02:27:09 UTC) #5
Emily Fortuna
8 years, 11 months ago (2012-01-18 02:31:26 UTC) #6 
https://chromiumcodereview.appspot.com/9252002/diff/2001/tools/testing/perf_t...
File tools/testing/perf_testing/perf_README.txt (right):

https://chromiumcodereview.appspot.com/9252002/diff/2001/tools/testing/perf_t...
tools/testing/perf_testing/perf_README.txt:94: b) copy the file in
/Library/Preferences/com.apple.Safari.plist to
$DARTDIR/tools/testing/com.apple.Safari.plist
True. I was working under the [bad] assumption that I'd probably be the only one
messing with this until I figure out a better solution. I'll add another warning
in there to remind myself to fix this once we have all our buildbots running.

On 2012/01/18 02:27:09, sigmund wrote:
> On 2012/01/18 02:20:36, Emily Fortuna wrote:
> > The plist file is some binary format from what I could tell. At least vim
> > couldn't read it.
> > 
> > In response to Siggi's comment here:
> >
>
https://chromiumcodereview.appspot.com/9252002/diff/2001/tools/testing/run_se...
> > the "original" is copied from Preferences to
> > $Dartdir/tools/testing/com.apple.Safari.plist, so we're just re-copying the
> > original preferences repeatedly over. So... generally the file is going to
be
> > the same that we're copying over. The only case when it would be different
is
> if
> > Safari deleted our preference settings (setting them back to the
> > factory-original), in which case we don't want to save that preferences
> file...
> > right? The file we're copying from never changes. So is a backup file really
> > recommended?
> > 
> > 
> > On 2012/01/18 01:35:51, John Messerly wrote:
> > > On 2012/01/18 01:12:37, Emily Fortuna wrote:
> > > > Yes, this is horribly hack-tastic. It's the best I've come up with so
far.
> > I'm
> > > > open to other ideas. :-/
> > > 
> > > we could try saving a copy of the plist file, and/or automatically editing
> it.
> > > Both have downsides though, depending on how often it changes in new
> versions.
> > 
> 
> I think it's ok, maybe we want to guard this in a flag one day (not needed
right
> now). My worry is that the dartdir copy is a one time step, if the user
changes
> the browser's preferences later, we'll override it.

Powered by Google App Engine
This is Rietveld 408576698