Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 9250009: Fix test.dart on Windows: change all backslashes to slashes eagerly. (Closed)

Created:
8 years, 11 months ago by Bill Hesse
Modified:
8 years, 11 months ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org, Emily Fortuna
Visibility:
Public.

Description

Fix test.dart on Windows: change all backslashes to slashes eagerly. BUG=dart:1206 TEST= Committed: https://code.google.com/p/dart/source/detail?r=3400

Patch Set 1 #

Patch Set 2 : fix error in stub_generator/test_config.dart #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M tests/stub-generator/test_config.dart View 1 2 chunks +2 lines, -1 line 0 comments Download
M tools/testing/dart/test_suite.dart View 4 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
8 years, 11 months ago (2012-01-18 15:53:55 UTC) #1
Mads Ager (google)
lgtm
8 years, 11 months ago (2012-01-18 16:05:58 UTC) #2
Bill Hesse
8 years, 11 months ago (2012-01-18 16:25:11 UTC) #3
On 2012/01/18 16:05:58, Mads Ager wrote:
> lgtm

TBR=ager@google.com
Fix for backslashes and wrong argument in stub-generator/test_config.test added.

Powered by Google App Engine
This is Rietveld 408576698