Issue 9245002: Support getters and setters.

Issue 9245002: Support getters and setters. (Closed)

Created:
8 years, 10 months ago by ngeoffray

Modified:
8 years, 8 months ago

Reviewers:
karlklose, ahe

CC:
reviews_dartlang.org, floitsch, Lasse Reichstein Nielsen, kasperl

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Support getters and setters. Committed: https://code.google.com/p/dart/source/detail?r=3792

Patch Set 3 : '' #

Total comments: 1

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+122 lines, -94 lines)			Patch
M	frog/leg/diagnostic_listener.dart	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	frog/leg/elements/elements.dart	View	1 2	4 chunks	+59 lines, -2 lines	0 comments	Download
M	frog/leg/namer.dart	View	1 2	2 chunks	+11 lines, -3 lines	0 comments	Download
M	frog/leg/resolver.dart	View	1 2	2 chunks	+20 lines, -13 lines	0 comments	Download
M	frog/leg/scanner/parser.dart	View	1 2	1 chunk	+1 line, -1 line	1 comment	Download
M	frog/leg/ssa/builder.dart	View	1 2	2 chunks	+10 lines, -10 lines	0 comments	Download
A +	frog/tests/leg_only/src/GettersSettersTest.dart	View		4 chunks	+19 lines, -61 lines	0 comments	Download
M	tests/language/language-leg.status	View	1 2	2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

https://chromiumcodereview.appspot.com/9245002/diff/2001/frog/tests/leg_only/src/GettersSettersTest.dart File frog/tests/leg_only/src/GettersSettersTest.dart (left): https://chromiumcodereview.appspot.com/9245002/diff/2001/frog/tests/leg_only/src/GettersSettersTest.dart#oldcode101 frog/tests/leg_only/src/GettersSettersTest.dart:101: B() : super() {} We don't support constructor super ...

8 years, 10 months ago (2012-01-31 16:39:26 UTC) #1

karlklose

LGTM. https://chromiumcodereview.appspot.com/9245002/diff/5001/frog/leg/elements/elements.dart File frog/leg/elements/elements.dart (right): https://chromiumcodereview.appspot.com/9245002/diff/5001/frog/leg/elements/elements.dart#newcode442 frog/leg/elements/elements.dart:442: element: element); align with first argument? https://chromiumcodereview.appspot.com/9245002/diff/5001/frog/leg/elements/elements.dart#newcode450 frog/leg/elements/elements.dart:450: ...

8 years, 10 months ago (2012-02-01 14:17:05 UTC) #2

ngeoffray

Thanks Karl https://chromiumcodereview.appspot.com/9245002/diff/5001/frog/leg/elements/elements.dart File frog/leg/elements/elements.dart (right): https://chromiumcodereview.appspot.com/9245002/diff/5001/frog/leg/elements/elements.dart#newcode442 frog/leg/elements/elements.dart:442: element: element); On 2012/02/01 14:17:06, karlklose wrote: ...

8 years, 10 months ago (2012-02-01 15:57:12 UTC) #3

ahe

8 years, 8 months ago (2012-04-18 12:13:50 UTC) #4

https://chromiumcodereview.appspot.com/9245002/diff/10001/frog/leg/scanner/pa...
File frog/leg/scanner/parser.dart (right):

https://chromiumcodereview.appspot.com/9245002/diff/10001/frog/leg/scanner/pa...
frog/leg/scanner/parser.dart:561: return peek;
Note to me: I think this code is duplicated in the class_element_parser.

Expand Messages | Collapse Messages