Issue 9241008: Remove dependency from platform/globals.h to platform/assert.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9241008: Remove dependency from platform/globals.h to platform/assert.h (Closed)

Created:
8 years, 11 months ago by Søren Gjesse

Modified:
8 years, 11 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove dependency from platform/globals.h to platform/assert.h R=ager@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=3347

Patch Set 2 : Addressed review comments from ager@ #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -3 lines)			Patch
	M	runtime/platform/globals.h	View	1	2 chunks	+9 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

lgtm https://chromiumcodereview.appspot.com/9241008/diff/1/runtime/platform/globals.h File runtime/platform/globals.h (right): https://chromiumcodereview.appspot.com/9241008/diff/1/runtime/platform/globals.h#newcode200 runtime/platform/globals.h:200: /* Don't use UNREACHABLE here to avoid circular ...

8 years, 11 months ago (2012-01-17 10:05:39 UTC) #2

Søren Gjesse

8 years, 11 months ago (2012-01-17 10:09:26 UTC) #3

https://chromiumcodereview.appspot.com/9241008/diff/1/runtime/platform/globals.h
File runtime/platform/globals.h (right):

https://chromiumcodereview.appspot.com/9241008/diff/1/runtime/platform/global...
runtime/platform/globals.h:200: /* Don't use UNREACHABLE here to avoid circular
dependencies between       \
On 2012/01/17 10:05:39, Mads Ager wrote:
> Move the comment above the macro definition and use '//'?

Done.

Expand Messages | Collapse Messages

Issue 9241008: Remove dependency from platform/globals.h to platform/assert.h (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed review comments from ager@ #

Messages