Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Issue 9235015: Update map literal syntax to expect only one type parameter (Closed)

Created:
8 years, 11 months ago by zundel
Modified:
8 years, 11 months ago
CC:
reviews_dartlang.org, Jacob
Visibility:
Public.

Description

Update map literal syntax to expect only one type parameter As of the spec v0.6, the correct syntax is now: <V>{"key" : value }; Whereas you used to also specify the key. Added a deprecation warning for the old syntax. http://code.google.com/p/dart/issues/detail?id=1151 Committed: https://code.google.com/p/dart/source/detail?r=3606

Patch Set 1 #

Total comments: 1

Messages

Total messages: 5 (0 generated)
zundel
@sra: I went ahead and updated the htmlimpl.dart by hand as well as the source ...
8 years, 11 months ago (2012-01-24 22:03:25 UTC) #1
scheglov
LGTM
8 years, 11 months ago (2012-01-25 15:16:20 UTC) #2
zundel
Spoke with sra privately and he suggested CC'ing nweiz and jacobr. Committed as r3606
8 years, 11 months ago (2012-01-25 20:27:29 UTC) #3
nweiz
lgtm In future, you can run "../tools/copy_dart.py release htmlimpl.dart" from client/html/ to automatically regenerate htmlimpl.
8 years, 11 months ago (2012-01-25 21:15:02 UTC) #4
Siggi Cherem (dart-lang)
8 years, 11 months ago (2012-01-25 23:26:53 UTC) #5
https://chromiumcodereview.appspot.com/9235015/diff/1/client/html/src/EventTa...
File client/html/src/EventTargetWrappingImplementation.dart (left):

https://chromiumcodereview.appspot.com/9235015/diff/1/client/html/src/EventTa...
client/html/src/EventTargetWrappingImplementation.dart:12: // TODO(sigmund): the
key type (String) yields a warning in frog and the vm,
Thanks Eric!

Powered by Google App Engine
This is Rietveld 408576698