Issue 9233039: Store resolved library prefix in unresolved class object in order not to repeat

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9233039: Store resolved library prefix in unresolved class object in order not to repeat (Closed)

Created:
8 years, 10 months ago by regis

Modified:
8 years, 10 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Store resolved library prefix in unresolved class object in order not to repeat unnecessary library prefix resolution. Remove redundant Type::NewParameterizedType() helper. Simplify parsing of qualified identifiers. Cleanup parsing of factory methods. Fix resolution of imported types (add tests). Committed: https://code.google.com/p/dart/source/detail?r=3703

Patch Set 1 #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+220 lines, -182 lines)			Patch
M	runtime/vm/class_finalizer.cc	View	1 chunk	+3 lines, -10 lines	0 comments	Download
M	runtime/vm/class_finalizer_test.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/code_generator_ia32.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/code_generator_x64.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/object.h	View	3 chunks	+5 lines, -6 lines	0 comments	Download
M	runtime/vm/object.cc	View	6 chunks	+10 lines, -15 lines	0 comments	Download
M	runtime/vm/parser.cc	View	19 chunks	+127 lines, -140 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/language/language.status	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	tests/language/language-leg.status	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	tests/language/src/FunctionTypeAlias3Test.dart	View	1 chunk	+28 lines, -0 lines	0 comments	Download
A	tests/language/src/FunctionTypeAlias4Test.dart	View	1 chunk	+36 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm, no objections :)

Expand Messages | Collapse Messages