Make test.dart run web tests on Windows.

Make changes to test.dart and frogsh for Windows.
This should enable frogsh to build correctly and function properly on Windows. 
test.dart is waiting on a fix in the VM before it will be fully ready.
Committed: https://code.google.com/p/dart/source/detail?r=3506

[Bill Hesse, 2012-01-22 20:52:02]

LGTM.

https://chromiumcodereview.appspot.com/9233015/diff/4019/frog/library.dart
File frog/library.dart (right):

https://chromiumcodereview.appspot.com/9233015/diff/4019/frog/library.dart#ne...
frog/library.dart:66: if (const RegExp('[a-zA-Z]:/').hasMatch(filename) &&
Can't we use an anchored regexp here, 
if (const RegExp('^[a-zA-Z]:/').hasMatch(filename)) return filename;
?

https://chromiumcodereview.appspot.com/9233015/diff/4019/tools/testing/dart/t...
File tools/testing/dart/test_runner.dart (right):

https://chromiumcodereview.appspot.com/9233015/diff/4019/tools/testing/dart/t...
tools/testing/dart/test_runner.dart:249: executable = executable.replaceAll('/',
'\\');
Should we file a bug, and make the Platform class deal with this?

https://chromiumcodereview.appspot.com/9233015/diff/4019/tools/testing/dart/t...
File tools/testing/dart/test_suite.dart (right):

https://chromiumcodereview.appspot.com/9233015/diff/4019/tools/testing/dart/t...
tools/testing/dart/test_suite.dart:415: // limit.
Let's file a bug - this needs to get fixed.

https://chromiumcodereview.appspot.com/9233015/diff/4019/tools/testing/dart/t...
tools/testing/dart/test_suite.dart:476: executable = executable.replaceAll('/',
'\\');
TODO, with bug number.

https://chromiumcodereview.appspot.com/9233015/diff/4019/tools/testing/dart/t...
tools/testing/dart/test_suite.dart:931: return 'frog/bin/frogsh$postfix';
Can't you just remove $postfix from this line here?

https://chromiumcodereview.appspot.com/9233015/diff/4019/tools/testing/run_se...
File tools/testing/run_selenium.py (right):

https://chromiumcodereview.appspot.com/9233015/diff/4019/tools/testing/run_se...
tools/testing/run_selenium.py:53: source = 'FAIL'
Can this be 'FAIL (timeout)', or does it need to be just the single word?

[Siggi Cherem (dart-lang), 2012-01-23 00:29:02]

drive by comments

https://chromiumcodereview.appspot.com/9233015/diff/4019/client/tools/buildbo...
File client/tools/buildbot_annotated_steps.py (right):

https://chromiumcodereview.appspot.com/9233015/diff/4019/client/tools/buildbo...
client/tools/buildbot_annotated_steps.py:184: os.environ['PATH'] =
(os.path.join('C:', 'Program Files (x86)', 'nodejs') +
wow

https://chromiumcodereview.appspot.com/9233015/diff/4019/client/tools/buildbo...
client/tools/buildbot_annotated_steps.py:189: env=os.environ, shell=True)
now that you have a frogsh.bat, is it needed to add 'nodejs' to the environment,
or could we add it to the path within frogsh.bat?

https://chromiumcodereview.appspot.com/9233015/diff/4019/tools/testing/dart/t...
File tools/testing/dart/test_suite.dart (right):

https://chromiumcodereview.appspot.com/9233015/diff/4019/tools/testing/dart/t...
tools/testing/dart/test_suite.dart:417: htmlFilename =
htmlFilename.substring(htmlFilename.length~/2);
could we do this selectively (only when we are close to the limit?)

https://chromiumcodereview.appspot.com/9233015/diff/4019/tools/testing/dart/t...
tools/testing/dart/test_suite.dart:449: if (libdir == '' && !
compilerExecutable.endsWith('frogsh')) {
remove space after !

https://chromiumcodereview.appspot.com/9233015/diff/4019/tools/testing/dart/t...
tools/testing/dart/test_suite.dart:452: if
(!compilerExecutable.endsWith('frogsh')) {
I thought there was going to be a different libdir for frogsh (instead of
nothing)

https://chromiumcodereview.appspot.com/9233015/diff/4019/tools/testing/dart/t...
tools/testing/dart/test_suite.dart:931: return 'frog/bin/frogsh$postfix';
On 2012/01/22 20:52:02, Bill Hesse wrote:
> Can't you just remove $postfix from this line here?

Also: if there is a postfix, it should be .bat in this case.

[Emily Fortuna, 2012-01-23 18:27:41]

https://chromiumcodereview.appspot.com/9233015/diff/4019/client/tools/buildbo...
File client/tools/buildbot_annotated_steps.py (right):

https://chromiumcodereview.appspot.com/9233015/diff/4019/client/tools/buildbo...
client/tools/buildbot_annotated_steps.py:184: os.environ['PATH'] =
(os.path.join('C:', 'Program Files (x86)', 'nodejs') +
Siggi, this is what we discussed, no?

On 2012/01/23 00:29:02, sigmund wrote:
> wow

https://chromiumcodereview.appspot.com/9233015/diff/4019/client/tools/buildbo...
client/tools/buildbot_annotated_steps.py:189: env=os.environ, shell=True)
We could... but it seems kind of hack-ish to assume that every Windows user is
going to have installed node.js in C:\Program Files (x86)\nodejs though. This
way we only make the assumption about the buildbot has nodejs installed in a
specific location.

On 2012/01/23 00:29:02, sigmund wrote:
> now that you have a frogsh.bat, is it needed to add 'nodejs' to the
environment,
> or could we add it to the path within frogsh.bat?

https://chromiumcodereview.appspot.com/9233015/diff/4019/frog/library.dart
File frog/library.dart (right):

https://chromiumcodereview.appspot.com/9233015/diff/4019/frog/library.dart#ne...
frog/library.dart:66: if (const RegExp('[a-zA-Z]:/').hasMatch(filename) &&
Much nicer. Done.

On 2012/01/22 20:52:02, Bill Hesse wrote:
> Can't we use an anchored regexp here, 
> if (const RegExp('^[a-zA-Z]:/').hasMatch(filename)) return filename;
> ?

https://chromiumcodereview.appspot.com/9233015/diff/4019/tools/testing/dart/t...
File tools/testing/dart/test_runner.dart (right):

https://chromiumcodereview.appspot.com/9233015/diff/4019/tools/testing/dart/t...
tools/testing/dart/test_runner.dart:249: executable = executable.replaceAll('/',
'\\');
We could... Currently this seems to be the default behavior from cmd.exe,
though. (For example, try running tools/test.py -- you'll get the message
"'tools' is not recognized as an internal or external command, operable program
or batch file") What do you think?

Update:
I've filed a bug here 1306: for discussion on this topic.

On 2012/01/22 20:52:02, Bill Hesse wrote:
> Should we file a bug, and make the Platform class deal with this?

https://chromiumcodereview.appspot.com/9233015/diff/4019/tools/testing/dart/t...
File tools/testing/dart/test_suite.dart (right):

https://chromiumcodereview.appspot.com/9233015/diff/4019/tools/testing/dart/t...
tools/testing/dart/test_suite.dart:415: // limit.
File a bug on Microsoft? This is a Windows API issue/decision. See "Maximum Path
Length Limitation" here: http://msdn.microsoft.com/en-us/library/aa365247.aspx 

On 2012/01/22 20:52:02, Bill Hesse wrote:
> Let's file a bug - this needs to get fixed.

https://chromiumcodereview.appspot.com/9233015/diff/4019/tools/testing/dart/t...
tools/testing/dart/test_suite.dart:449: if (libdir == '' && !
compilerExecutable.endsWith('frogsh')) {
On 2012/01/23 00:29:02, sigmund wrote:
> remove space after !

Done.

https://chromiumcodereview.appspot.com/9233015/diff/4019/tools/testing/dart/t...
tools/testing/dart/test_suite.dart:476: executable = executable.replaceAll('/',
'\\');
On 2012/01/22 20:52:02, Bill Hesse wrote:
> TODO, with bug number.

Done.

https://chromiumcodereview.appspot.com/9233015/diff/4019/tools/testing/dart/t...
tools/testing/dart/test_suite.dart:931: return 'frog/bin/frogsh$postfix';
@Siggi: For windows you can call the .bat file without the .bat extension.
@Bill: Touché. Done.

On 2012/01/23 00:29:02, sigmund wrote:
> On 2012/01/22 20:52:02, Bill Hesse wrote:
> > Can't you just remove $postfix from this line here?
> 
> Also: if there is a postfix, it should be .bat in this case.

https://chromiumcodereview.appspot.com/9233015/diff/4019/tools/testing/run_se...
File tools/testing/run_selenium.py (right):

https://chromiumcodereview.appspot.com/9233015/diff/4019/tools/testing/run_se...
tools/testing/run_selenium.py:53: source = 'FAIL'
Fixed!

On 2012/01/22 20:52:02, Bill Hesse wrote:
> Can this be 'FAIL (timeout)', or does it need to be just the single word?

[Emily Fortuna, 2012-01-23 19:18:49]

https://chromiumcodereview.appspot.com/9233015/diff/4019/tools/testing/dart/t...
File tools/testing/dart/test_suite.dart (right):

https://chromiumcodereview.appspot.com/9233015/diff/4019/tools/testing/dart/t...
tools/testing/dart/test_suite.dart:415: // limit.
Talked to Siggi about this. Once you fix your above TODO (just use test.hml
instead of getHtmlName) this problem should go away.

On 2012/01/23 18:27:41, Emily Fortuna wrote:
> File a bug on Microsoft? This is a Windows API issue/decision. See "Maximum
Path
> Length Limitation" here: http://msdn.microsoft.com/en-us/library/aa365247.aspx

> 
> On 2012/01/22 20:52:02, Bill Hesse wrote:
> > Let's file a bug - this needs to get fixed.
>

[Bill Hesse, 2012-01-24 09:29:22]

lgtm

https://chromiumcodereview.appspot.com/9233015/diff/15002/tools/testing/dart/...
File tools/testing/dart/test_suite.dart (right):

https://chromiumcodereview.appspot.com/9233015/diff/15002/tools/testing/dart/...
tools/testing/dart/test_suite.dart:925: configuration['component'] !=
'webdriver')) ? '.exe' : '';
I meant that 2/3 of the condition here can be eliminated, since postfix is
ignored in the frogium and webdriver cases.

[Emily Fortuna, 2012-01-24 17:20:22]

https://chromiumcodereview.appspot.com/9233015/diff/15002/tools/testing/dart/...
File tools/testing/dart/test_suite.dart (right):

https://chromiumcodereview.appspot.com/9233015/diff/15002/tools/testing/dart/...
tools/testing/dart/test_suite.dart:925: configuration['component'] !=
'webdriver')) ? '.exe' : '';
Right. I ended up fixing it in a new CL here
(https://chromiumcodereview.appspot.com/9117010/), because I originally had to
revert this one since this checkin broke all of frog *except* Windows! (the line
that caused the problem was 187 in buildbot_annotated_steps.py)

On 2012/01/24 09:29:22, Bill Hesse wrote:
> I meant that 2/3 of the condition here can be eliminated, since postfix is
> ignored in the frogium and webdriver cases.