Issue 9232044: Skip language/StringEscape1NegativeTest on Dartium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9232044: Skip language/StringEscape1NegativeTest on Dartium. (Closed)

Created:
8 years, 10 months ago by Anton Muhin

Modified:
8 years, 10 months ago

Reviewers:
ahe, antonm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Skip language/StringEscape1NegativeTest on Dartium. Committed: https://code.google.com/p/dart/source/detail?r=3643

Patch Set 1 #

Total comments: 2

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tests/language/language.status	View		1 chunk	+1 line, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

antonm

TBRing I don't know why fail didn't work, let's just skip to make the world ...

8 years, 10 months ago (2012-01-27 10:07:30 UTC) #1

ahe

https://chromiumcodereview.appspot.com/9232044/diff/1/tests/language/language.status File tests/language/language.status (right): https://chromiumcodereview.appspot.com/9232044/diff/1/tests/language/language.status#newcode65 tests/language/language.status:65: StringEscape1NegativeTest: Skip This test is now skipped on both ...

8 years, 10 months ago (2012-01-27 12:19:43 UTC) #2

antonm

8 years, 10 months ago (2012-01-27 12:48:06 UTC) #3

https://chromiumcodereview.appspot.com/9232044/diff/1/tests/language/language...
File tests/language/language.status (right):

https://chromiumcodereview.appspot.com/9232044/diff/1/tests/language/language...
tests/language/language.status:65: StringEscape1NegativeTest: Skip
On 2012/01/27 12:19:43, ahe wrote:
> This test is now skipped on both dartium and vm components. Was that your
> intent?

No, thanks a lot for catching, see
https://chromiumcodereview.appspot.com/9298007/

Expand Messages | Collapse Messages