Issue 9232017: Improve function compilation times for swarm application startup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9232017: Improve function compilation times for swarm application startup. (Closed)

Created:
8 years, 11 months ago by siva

Modified:
8 years, 11 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Improve function compilation times for swarm application startup. - Add a String::Equals(const String& str) method. - Pass in isolate parameter if present for some handle creation functions. Committed: https://code.google.com/p/dart/source/detail?r=3413

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -31 lines)			Patch
M	vm/object.h	View	1	1 chunk	+9 lines, -0 lines	2 comments	Download
M	vm/object.cc	View		8 chunks	+38 lines, -28 lines	0 comments	Download
M	vm/parser.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM with comment. -Ivan http://codereview.chromium.org/9232017/diff/6001/vm/object.h File vm/object.h (right): http://codereview.chromium.org/9232017/diff/6001/vm/object.h#newcode2642 vm/object.h:2642: } Do you want to ...

8 years, 11 months ago (2012-01-18 19:44:30 UTC) #3

siva

8 years, 11 months ago (2012-01-18 20:01:06 UTC) #4

http://codereview.chromium.org/9232017/diff/6001/vm/object.h
File vm/object.h (right):

http://codereview.chromium.org/9232017/diff/6001/vm/object.h#newcode2642
vm/object.h:2642: }
As discussed offline, introducing the hash check seems to degrade performance. I
think additional checks introduced do not pay off enough.

On 2012/01/18 19:44:30, Ivan Posva wrote:
> Do you want to inline the hash check here?

Expand Messages | Collapse Messages