Issue 9232016: Ignore parsed types of local variables in unchecked mode and replace them with

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9232016: Ignore parsed types of local variables in unchecked mode and replace them with (Closed)

Created:
8 years, 11 months ago by regis

Modified:
8 years, 11 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Ignore parsed types of local variables in unchecked mode and replace them with the Dynamic type. Committed: https://code.google.com/p/dart/source/detail?r=3404

Patch Set 4 : '' #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -29 lines)			Patch
M	runtime/vm/parser.h	View	1 2 3	2 chunks	+2 lines, -8 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1 2 3	8 chunks	+23 lines, -16 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1 2 3	3 chunks	+8 lines, -4 lines	0 comments	Download
M	tests/language/language.status	View	1 2 3	2 chunks	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hausner

LGTM https://chromiumcodereview.appspot.com/9232016/diff/1006/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://chromiumcodereview.appspot.com/9232016/diff/1006/runtime/vm/parser.cc#newcode4656 runtime/vm/parser.cc:4656: ParseFinalVarOrType(kMustResolve)); We may want to check with Gilad ...

8 years, 11 months ago (2012-01-18 17:50:57 UTC) #2

regis

8 years, 11 months ago (2012-01-18 18:09:18 UTC) #3

Thanks!

https://chromiumcodereview.appspot.com/9232016/diff/1006/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://chromiumcodereview.appspot.com/9232016/diff/1006/runtime/vm/parser.cc...
runtime/vm/parser.cc:4656: ParseFinalVarOrType(kMustResolve));
On 2012/01/18 17:50:57, hausner wrote:
> We may want to check with Gilad to make sure this type must resolve. I'd
> definitely say it has to, but one never knows...

I have added a comment stating that the type must always be resolved, even in
unchecked mode. This is consistent with the spec.

Expand Messages | Collapse Messages

Issue 9232016: Ignore parsed types of local variables in unchecked mode and replace them with (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Messages