Issue 9231021: Several fixes needed to reuse JS DOM interfaces in dartium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9231021: Several fixes needed to reuse JS DOM interfaces in dartium. (Closed)

Created:
8 years, 11 months ago by podivilov

Modified:
8 years, 11 months ago

Reviewers:
vsm, sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Several fixes needed to reuse JS DOM interfaces in dartium. - make generator output dir configurable - templates dir should be relative to dartdomgenerator.py rather then current directory - "operator" is keyword and could not be an attribute name R=sra@google.com,vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=3454

Patch Set 1 #

Total comments: 2

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -18 lines)			Patch
M	client/dom/idl/dart/dart.idl	View	2 chunks	+12 lines, -2 lines	2 comments	Download
M	client/dom/scripts/dartdomgenerator.py	View	4 chunks	+12 lines, -12 lines	0 comments	Download
M	client/dom/scripts/dartgenerator.py	View	3 chunks	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sra1

lgtm http://codereview.chromium.org/9231021/diff/1/client/dom/idl/dart/dart.idl File client/dom/idl/dart/dart.idl (right): http://codereview.chromium.org/9231021/diff/1/client/dom/idl/dart/dart.idl#newcode184 client/dom/idl/dart/dart.idl:184: [Suppressed] readonly attribute SVGAnimatedEnumeration operator; Is this necessary? ...

8 years, 11 months ago (2012-01-17 22:13:30 UTC) #2

podivilov

8 years, 11 months ago (2012-01-20 11:26:58 UTC) #3

Thanks!

http://codereview.chromium.org/9231021/diff/1/client/dom/idl/dart/dart.idl
File client/dom/idl/dart/dart.idl (right):

http://codereview.chromium.org/9231021/diff/1/client/dom/idl/dart/dart.idl#ne...
client/dom/idl/dart/dart.idl:184: [Suppressed] readonly attribute
SVGAnimatedEnumeration operator;
On 2012/01/17 22:13:30, sra1 wrote:
> Is this necessary? 'operator' is a pseudo-keyword.
> 
> See
>
http://codereview.chromium.org/9212018/diff/4/tests/language/src/PseudoKWTest...
> 
> If there is a problem with 'operator', can you put in a 'TODO' to remove after
> the problem is fixed?

Reverted.

Expand Messages | Collapse Messages