Issue 9231020: Use platform implementation of Monitor in thread pool

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9231020: Use platform implementation of Monitor in thread pool (Closed)

Created:
8 years, 11 months ago by Søren Gjesse

Modified:
8 years, 11 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Use platform implementation of Monitor in thread pool This removes the direct use of pthread API for the thread pool monitor now that that code is shared. It also gets the Windows implementation for free. Next step will be to get rid of using the pthread API for handling the threads as well, but that requires additional operations on the Thread class in platform/thread.h. R=ager@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=3362

Patch Set 1 #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+47 lines, -189 lines)			Patch
M	runtime/bin/thread_pool.h	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	runtime/bin/thread_pool.cc	View	1 chunk	+44 lines, -0 lines	0 comments	Download
M	runtime/bin/thread_pool_linux.h	View	1 chunk	+0 lines, -18 lines	0 comments	Download
M	runtime/bin/thread_pool_linux.cc	View	1 chunk	+0 lines, -59 lines	0 comments	Download
M	runtime/bin/thread_pool_macos.h	View	1 chunk	+0 lines, -18 lines	0 comments	Download
M	runtime/bin/thread_pool_macos.cc	View	1 chunk	+0 lines, -59 lines	0 comments	Download
M	runtime/bin/thread_pool_win.h	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	runtime/bin/thread_pool_win.cc	View	1 chunk	+0 lines, -21 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages