New dart.js bootstrap script for apps

New dart.js bootstrap script for apps

The primary new add is the dart.js script.  All sample html files now point to it, and were tested with Dartium, Chrome, and FireFox.

I've checked in compiled JS so the samples 'just work'.  They were compiled via frog:

frog/minfrog --compile-only --out=client/samples/sunflower/Sunflower.dart.js client/samples/sunflower/Sunflower.dart

If you guys prefer, I can take these out.

Committed: https://code.google.com/p/dart/source/detail?r=3480

[dgrove, 2012-01-20 20:56:52]

On 2012/01/20 20:44:12, vsm wrote:

I'd prefer to not check in the JS here - it means that someone has to keep that
JS up-to-date.

[dgrove, 2012-01-20 20:57:03]

http://codereview.chromium.org/9226025/diff/1/client/dart.js
File client/dart.js (right):

http://codereview.chromium.org/9226025/diff/1/client/dart.js#newcode21
client/dart.js:21: document.body.appendChild(script);
won't this break scripts that want to look at their parent? (e.g., they're
counting on executing at a specific point in the DOM?)

http://codereview.chromium.org/9226025/diff/1/client/samples/dartcombat/dartc...
File client/samples/dartcombat/dartcombat.html (right):

http://codereview.chromium.org/9226025/diff/1/client/samples/dartcombat/dartc...
client/samples/dartcombat/dartcombat.html:13: <script
src="../../dart.js"></script>
I think we should pull this in from dartlang.org to make these less brittle
(otherwise, as we move these around, this won't work)

http://codereview.chromium.org/9226025/diff/1/client/samples/hi/hi.html
File client/samples/hi/hi.html (right):

http://codereview.chromium.org/9226025/diff/1/client/samples/hi/hi.html#newco...
client/samples/hi/hi.html:12: <script src="../../dart.js"></script>
ditto

http://codereview.chromium.org/9226025/diff/1/client/samples/isolate/isolate_...
File client/samples/isolate/isolate_sample.html (right):

http://codereview.chromium.org/9226025/diff/1/client/samples/isolate/isolate_...
client/samples/isolate/isolate_sample.html:41: <script
src="../../dart.js"></script>
ditto

http://codereview.chromium.org/9226025/diff/1/client/samples/logo/logo.html
File client/samples/logo/logo.html (right):

http://codereview.chromium.org/9226025/diff/1/client/samples/logo/logo.html#n...
client/samples/logo/logo.html:24: <script src="../../dart.js"></script>
ditto

http://codereview.chromium.org/9226025/diff/1/client/samples/slider/slider_sa...
File client/samples/slider/slider_sample.html (right):

http://codereview.chromium.org/9226025/diff/1/client/samples/slider/slider_sa...
client/samples/slider/slider_sample.html:22: <script
src="../../dart.js"></script>
ditto

http://codereview.chromium.org/9226025/diff/1/client/samples/spirodraw/spirod...
File client/samples/spirodraw/spirodraw.html (right):

http://codereview.chromium.org/9226025/diff/1/client/samples/spirodraw/spirod...
client/samples/spirodraw/spirodraw.html:118: <script
src="../../dart.js"></script>
ditto

http://codereview.chromium.org/9226025/diff/1/client/samples/sunflower/sunflo...
File client/samples/sunflower/sunflower.html (right):

http://codereview.chromium.org/9226025/diff/1/client/samples/sunflower/sunflo...
client/samples/sunflower/sunflower.html:26: <script
src="../../dart.js"></script>
ditto

http://codereview.chromium.org/9226025/diff/1/client/samples/swarm/swarm.html
File client/samples/swarm/swarm.html (right):

http://codereview.chromium.org/9226025/diff/1/client/samples/swarm/swarm.html...
client/samples/swarm/swarm.html:39: <script src="../../dart.js"></script>
ditto

[danrubel, 2012-01-20 21:20:36]

On 2012/01/20 20:56:52, dgrove wrote:
> On 2012/01/20 20:44:12, vsm wrote:
> 
> I'd prefer to not check in the JS here - it means that someone has to keep
that
> JS up-to-date.

 +1

http://codereview.chromium.org/9226025/diff/1/client/dart.js
File client/dart.js (right):

http://codereview.chromium.org/9226025/diff/1/client/dart.js#newcode9
client/dart.js:9: // Fall back to compiled JS.
Do we need a "is Dart available in this browser" check here so that samples will
run "natively" in Dartium?

[vsm, 2012-01-20 21:55:27]

PTAL

I've dropped the generated JS.  I'll modify the sample html files in a separate
CL so we can figure out the canonical URL for this.

http://codereview.chromium.org/9226025/diff/1/client/dart.js
File client/dart.js (right):

http://codereview.chromium.org/9226025/diff/1/client/dart.js#newcode9
client/dart.js:9: // Fall back to compiled JS.
On 2012/01/20 21:20:36, danrubel wrote:
> Do we need a "is Dart available in this browser" check here so that samples
will
> run "natively" in Dartium?

Line 7 is that check.  Note, we will probably change how to do the check, but
only this file needs updating.

http://codereview.chromium.org/9226025/diff/1/client/dart.js#newcode21
client/dart.js:21: document.body.appendChild(script);
Modified to replace the original script.

On 2012/01/20 20:57:03, dgrove wrote:
> won't this break scripts that want to look at their parent? (e.g., they're
> counting on executing at a specific point in the DOM?)

[dgrove, 2012-01-20 22:01:13]

assuming the replaceChild madness really works, lgtm!

http://codereview.chromium.org/9226025/diff/3007/client/dart.js
File client/dart.js (right):

http://codereview.chromium.org/9226025/diff/3007/client/dart.js#newcode22
client/dart.js:22: parent.replaceChild(script, scripts[i]);
does this really work? (ie, the script starts executing?) if so, cool!