Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issue 9205003: Test that expose a few quirks in the Dart VM parser. (Closed)

Created:
8 years, 11 months ago by ahe
Modified:
8 years, 8 months ago
Reviewers:
gbracha, hausner, kasperl
CC:
reviews_dartlang.org, hausner
Visibility:
Public.

Description

Test that expose a few quirks in the Dart VM parser. Committed: https://code.google.com/p/dart/source/detail?r=6783

Patch Set 1 : changes #

Total comments: 2

Patch Set 2 : Rebased #

Patch Set 3 : Add comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
A dart/tests/language/src/ParserQuirksTest.dart View 1 2 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ahe
8 years, 11 months ago (2012-01-13 13:21:30 UTC) #1
hausner
DBQ http://codereview.chromium.org/9205003/diff/2001/dart/tests/language/src/ParserQuirksTest.dart File dart/tests/language/src/ParserQuirksTest.dart (right): http://codereview.chromium.org/9205003/diff/2001/dart/tests/language/src/ParserQuirksTest.dart#newcode4 dart/tests/language/src/ParserQuirksTest.dart:4: Would you mind adding a comment with expected ...
8 years, 11 months ago (2012-01-13 16:27:31 UTC) #2
ahe
http://codereview.chromium.org/9205003/diff/2001/dart/tests/language/src/ParserQuirksTest.dart File dart/tests/language/src/ParserQuirksTest.dart (right): http://codereview.chromium.org/9205003/diff/2001/dart/tests/language/src/ParserQuirksTest.dart#newcode4 dart/tests/language/src/ParserQuirksTest.dart:4: On 2012/01/13 16:27:32, hausner wrote: > Would you mind ...
8 years, 11 months ago (2012-01-13 17:00:42 UTC) #3
kasperl
LGTM.
8 years, 11 months ago (2012-01-16 06:53:01 UTC) #4
ahe
8 years, 8 months ago (2012-04-20 08:31:05 UTC) #5
Finally submitted with a few comments.

Powered by Google App Engine
This is Rietveld 408576698