Move Mutex and Monitor from vm/ to platform/

Move Mutex and Monitor from vm/ to platform/

The tests are still in runtime/vm/thread_test.cc.

R=ager@google.com, iposva@google.com

BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=3349

[Søren Gjesse, 2012-01-13 14:22:39]

This is based on http://codereview.chromium.org/9189003/ where assert.h and
assert.cc have already been moved to platform/runtime

[Ivan Posva, 2012-01-13 23:33:41]

http://codereview.chromium.org/9196002/diff/1/runtime/platform/platform_heade...
File runtime/platform/platform_headers.gypi (right):

http://codereview.chromium.org/9196002/diff/1/runtime/platform/platform_heade...
runtime/platform/platform_headers.gypi:12: 'thread.h',
thread_linux.h,
thread_macos.h,
thread_win.h,

http://codereview.chromium.org/9196002/diff/1/runtime/platform/platform_sourc...
File runtime/platform/platform_sources.gypi (right):

http://codereview.chromium.org/9196002/diff/1/runtime/platform/platform_sourc...
runtime/platform/platform_sources.gypi:9: 'thread.h',
Why are thread*.h files duplicated here? This is inconsistent compared to the
other headers in the platform directory. As far as I am concerned these .h files
belong into the platform_headers.gypi.

http://codereview.chromium.org/9196002/diff/1/runtime/platform/thread.h
File runtime/platform/thread.h (right):

http://codereview.chromium.org/9196002/diff/1/runtime/platform/thread.h#newco...
runtime/platform/thread.h:22: 
Why is class Thread not part of the header platform/thread.h?

http://codereview.chromium.org/9196002/diff/1/runtime/platform/thread_linux.cc
File runtime/platform/thread_linux.cc (right):

http://codereview.chromium.org/9196002/diff/1/runtime/platform/thread_linux.c...
runtime/platform/thread_linux.cc:9: #include "vm/thread.h"
vm/thread.h does that even exist?

[Søren Gjesse, 2012-01-16 16:12:18]

http://codereview.chromium.org/9196002/diff/1/runtime/platform/platform_heade...
File runtime/platform/platform_headers.gypi (right):

http://codereview.chromium.org/9196002/diff/1/runtime/platform/platform_heade...
runtime/platform/platform_headers.gypi:12: 'thread.h',
On 2012/01/13 23:33:41, Ivan Posva wrote:
> thread_linux.h,
> thread_macos.h,
> thread_win.h,

Of cause - thanks!

http://codereview.chromium.org/9196002/diff/1/runtime/platform/platform_sourc...
File runtime/platform/platform_sources.gypi (right):

http://codereview.chromium.org/9196002/diff/1/runtime/platform/platform_sourc...
runtime/platform/platform_sources.gypi:9: 'thread.h',
On 2012/01/13 23:33:41, Ivan Posva wrote:
> Why are thread*.h files duplicated here? This is inconsistent compared to the
> other headers in the platform directory. As far as I am concerned these .h
files
> belong into the platform_headers.gypi.

They do - moved.

http://codereview.chromium.org/9196002/diff/1/runtime/platform/thread.h
File runtime/platform/thread.h (right):

http://codereview.chromium.org/9196002/diff/1/runtime/platform/thread.h#newco...
runtime/platform/thread.h:22: 
On 2012/01/13 23:33:41, Ivan Posva wrote:
> Why is class Thread not part of the header platform/thread.h?

I was not sure we needed it but it makes sense to move it anyway.

http://codereview.chromium.org/9196002/diff/1/runtime/platform/thread_linux.cc
File runtime/platform/thread_linux.cc (right):

http://codereview.chromium.org/9196002/diff/1/runtime/platform/thread_linux.c...
runtime/platform/thread_linux.cc:9: #include "vm/thread.h"
On 2012/01/13 23:33:41, Ivan Posva wrote:
> vm/thread.h does that even exist?

Changed to platform/thread.h. vm/thread.h does still exist - it contains the
MonitorLocker and MutexLocker stack resources.

[Mads Ager (google), 2012-01-16 16:30:36]

LGTM with a couple of questions.

http://codereview.chromium.org/9196002/diff/11001/runtime/platform/thread_win.cc
File runtime/platform/thread_win.cc (right):

http://codereview.chromium.org/9196002/diff/11001/runtime/platform/thread_win...
runtime/platform/thread_win.cc:10: #include "platform/globals.h"
I guess there are added to explicity include what you need? platform/globals.h
is included from platform/thread.h too I think? In the other thread_ files as
well.

http://codereview.chromium.org/9196002/diff/11001/runtime/vm/native_arguments.cc
File runtime/vm/native_arguments.cc (right):

http://codereview.chromium.org/9196002/diff/11001/runtime/vm/native_arguments...
runtime/vm/native_arguments.cc:8: #include "vm/globals.h"
What here needs globals.h?

[Søren Gjesse, 2012-01-17 10:28:57]

https://chromiumcodereview.appspot.com/9196002/diff/11001/runtime/platform/th...
File runtime/platform/thread_win.cc (right):

https://chromiumcodereview.appspot.com/9196002/diff/11001/runtime/platform/th...
runtime/platform/thread_win.cc:10: #include "platform/globals.h"
On 2012/01/16 16:30:37, Mads Ager wrote:
> I guess there are added to explicity include what you need? platform/globals.h
> is included from platform/thread.h too I think? In the other thread_ files as
> well.

Right - removed as it is not really needed.

https://chromiumcodereview.appspot.com/9196002/diff/11001/runtime/vm/native_a...
File runtime/vm/native_arguments.cc (right):

https://chromiumcodereview.appspot.com/9196002/diff/11001/runtime/vm/native_a...
runtime/vm/native_arguments.cc:8: #include "vm/globals.h"
On 2012/01/16 16:30:37, Mads Ager wrote:
> What here needs globals.h?

None - removed.