Issue 9195006: Test.dart will wait for the temporary directory to be deleted before exiting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9195006: Test.dart will wait for the temporary directory to be deleted before exiting. (Closed)

Created:
8 years, 11 months ago by Bill Hesse

Modified:
8 years, 11 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Test.dart will wait for the temporary directory to be deleted before exiting. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=3429

Patch Set 1 #

Patch Set 2 : Add report of temporary deletion status. #

Patch Set 3 : Add newline before temp dir deletion report. #

Total comments: 1

Patch Set 4 : Add a space between the handler parameter list and the opening brace of its body. #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	tools/testing/dart/test_runner.dart	View	1 2 3	1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ricow1

8 years, 11 months ago (2012-01-19 10:20:34 UTC) #2

LGTM

http://codereview.chromium.org/9195006/diff/4001/tools/testing/dart/test_runn...
File tools/testing/dart/test_runner.dart (right):

http://codereview.chromium.org/9195006/diff/4001/tools/testing/dart/test_runn...
tools/testing/dart/test_runner.dart:482: deletion.exitHandler = (int exitCode){
add space before {

Expand Messages | Collapse Messages