Issue 9193014: Save and restore errno in signal handler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9193014: Save and restore errno in signal handler. (Closed)

Created:
8 years, 11 months ago by Mads Ager (google)

Modified:
8 years, 11 months ago

Reviewers:
Søren Gjesse, Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Save and restore errno in signal handler. Having a signal handler that clobbers errno can lead to spurious behavior in other code that relies on errno. One example of this is pthread_cond_wait. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=3499

Patch Set 1 #

Patch Set 2 : Add Windows binary so base version is the same. #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, --3 lines)			Patch
M	runtime/bin/process_linux.cc	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	runtime/bin/process_macos.cc	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	tools/testing/bin/linux/dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	tools/testing/bin/macos/dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	tools/testing/bin/windows/dart.exe	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages