Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 9190042: Add test case for utils/utf8/utf8.dart. (Closed)

Created:
8 years, 11 months ago by ahe
Modified:
8 years, 8 months ago
CC:
reviews_dartlang.org, Lasse Reichstein Nielsen, Søren Gjesse
Visibility:
Public.

Description

Add test case for utils/utf8/utf8.dart. Committed: https://code.google.com/p/dart/source/detail?r=6784

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Moved test to utils #

Total comments: 2

Patch Set 4 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -0 lines) Patch
A dart/tests/utils/src/Utf8Test.dart View 1 2 3 1 chunk +49 lines, -0 lines 0 comments Download
M dart/tests/utils/utils.status View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ahe
I solemnly swear that I'll move this test to dart/tests/utils when test.py is dead.
8 years, 11 months ago (2012-01-12 15:37:50 UTC) #1
kasperl
It sounds to me like everybody agrees that this test should live with the tests ...
8 years, 11 months ago (2012-01-16 08:48:18 UTC) #2
ahe
PTAL
8 years, 8 months ago (2012-04-20 09:21:24 UTC) #3
kasperl
LGTM. https://chromiumcodereview.appspot.com/9190042/diff/6003/dart/tests/utils/src/Utf8Test.dart File dart/tests/utils/src/Utf8Test.dart (right): https://chromiumcodereview.appspot.com/9190042/diff/6003/dart/tests/utils/src/Utf8Test.dart#newcode5 dart/tests/utils/src/Utf8Test.dart:5: // TODO(ahe): This test should be moved to ...
8 years, 8 months ago (2012-04-20 09:22:54 UTC) #4
ahe
Thank you, Kasper. https://chromiumcodereview.appspot.com/9190042/diff/6003/dart/tests/utils/src/Utf8Test.dart File dart/tests/utils/src/Utf8Test.dart (right): https://chromiumcodereview.appspot.com/9190042/diff/6003/dart/tests/utils/src/Utf8Test.dart#newcode5 dart/tests/utils/src/Utf8Test.dart:5: // TODO(ahe): This test should be ...
8 years, 8 months ago (2012-04-20 09:26:45 UTC) #5
Søren Gjesse
8 years, 8 months ago (2012-04-20 11:04:38 UTC) #6
lgtm

Powered by Google App Engine
This is Rietveld 408576698