Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 9178030: Add tests for Element#elements. (Closed)

Created:
8 years, 11 months ago by nweiz
Modified:
8 years, 11 months ago
Reviewers:
sra, Jacob
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add tests for Element#elements. This also factors out some of the range functions in NodeList and adds them to _Lists. _Lists was then renamed to Lists so it could be accessed from the testing code. This was originally submitted as r3320. That was rolled back due to errors in the dartium bot, but the logs are unavailable and local tests seem to pass so we're rolling forward again. TBR Committed: https://code.google.com/p/dart/source/detail?r=3374

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+528 lines, -443 lines) Patch
M client/html/generated/src/wrapping/_CanvasPixelArrayWrappingImplementation.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M client/html/generated/src/wrapping/_MediaListWrappingImplementation.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M client/html/generated/src/wrapping/_StyleSheetListWrappingImplementation.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M client/html/generated/src/wrapping/_TouchListWrappingImplementation.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M client/html/htmlimpl.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/html/release/htmlimpl.dart View 11 chunks +85 lines, -111 lines 0 comments Download
M client/html/src/ElementWrappingImplementation.dart View 3 chunks +11 lines, -33 lines 0 comments Download
A client/html/src/Lists.dart View 1 chunk +107 lines, -0 lines 0 comments Download
M client/html/src/NodeWrappingImplementation.dart View 2 chunks +9 lines, -69 lines 0 comments Download
D client/html/src/_Lists.dart View 1 chunk +0 lines, -51 lines 0 comments Download
M client/tests/client/html/ElementTests.dart View 2 chunks +146 lines, -0 lines 0 comments Download
A client/tests/client/html/ListsTests.dart View 1 chunk +159 lines, -0 lines 0 comments Download
M client/tests/client/html/NodeTests.dart View 1 chunk +0 lines, -170 lines 0 comments Download
M client/tests/client/html/html_tests.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
nweiz
8 years, 11 months ago (2012-01-17 22:33:35 UTC) #1
Jacob
8 years, 11 months ago (2012-01-18 19:23:51 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698