Issue 9178022: Fix test.dart to have the same behavior as test.py for --frog and --froglib.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9178022: Fix test.dart to have the same behavior as test.py for --frog and --froglib. (Closed)

Created:
8 years, 11 months ago by Emily Fortuna

Modified:
8 years, 11 months ago

Reviewers:
Bill Hesse, Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix test.dart to have the same behavior as test.py for --frog and --froglib. (Fixing Issue 1046) Committed: https://code.google.com/p/dart/source/detail?r=3366

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -5 lines)			Patch
	M	tools/testing/dart/test_options.dart	View		1 chunk	+9 lines, -3 lines	0 comments	Download
	M	tools/testing/dart/test_suite.dart	View	1	3 chunks	+10 lines, -2 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

8 years, 11 months ago (2012-01-19 16:31:28 UTC) #3

https://chromiumcodereview.appspot.com/9178022/diff/3001/tools/testing/dart/t...
File tools/testing/dart/test_suite.dart (right):

https://chromiumcodereview.appspot.com/9178022/diff/3001/tools/testing/dart/t...
tools/testing/dart/test_suite.dart:936: var name = configuration['frog'];
I don't think we want --frog to override the dartc path if component =
'chromium' or 'dartc'.  This could happen with
test.dart -cchromium,frogium --frog=i_built/this/frogsh.
Could this be
if (configuration['frog'] != '' && (configuration['component'] == 'frogium' ||
... 'webkit')) {
 name = configuration['frog'];
} else {
 name = ....
}

Expand Messages | Collapse Messages