Issue 9178020: Revert "Remove TypeToken as means for assigning type arguments to arrays."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9178020: Revert "Remove TypeToken as means for assigning type arguments to arrays." (Closed)

Created:
8 years, 11 months ago by mmendez

Modified:
8 years, 11 months ago

Reviewers:
floitsch, codefu, zundel

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Remove TypeToken as means for assigning type arguments to arrays." This reverts commit r3356. Apparently closure will optimize new Array(x) to Array(void 0). Committed: https://code.google.com/p/dart/source/detail?r=3360

Patch Set 1 #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -16 lines)			Patch
M	compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java	View	2 chunks	+0 lines, -12 lines	0 comments	Download
M	compiler/lib/corelib_impl.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	compiler/lib/implementation/array.dart	View	2 chunks	+6 lines, -4 lines	0 comments	Download
M	compiler/lib/implementation/array.js	View	1 chunk	+6 lines, -0 lines	0 comments	Download
A	compiler/lib/implementation/type_token.dart	View	1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mmendez

Reverting this change since closure optimizations break it. Will re-roll it once I figure out ...

8 years, 11 months ago (2012-01-17 15:29:09 UTC) #1

lgtm

Expand Messages | Collapse Messages