Add script attribute to Options class, providing the name of the running script.

Add script attribute to Options class, providing the name of the running script.


BUG=dart:409
TEST=standalone/OptionsTest

Committed: https://code.google.com/p/dart/source/detail?r=3485

[Mads Ager (google), 2012-01-20 11:38:03]

lgtm

http://codereview.chromium.org/9159013/diff/1/corelib/src/implementation/opti...
File corelib/src/implementation/options.dart (right):

http://codereview.chromium.org/9159013/diff/1/corelib/src/implementation/opti...
corelib/src/implementation/options.dart:20: // This arguments singleton is
overriden by the embedder if applicable.
overridden?

http://codereview.chromium.org/9159013/diff/1/corelib/src/implementation/opti...
corelib/src/implementation/options.dart:23: static String _nativeScript = null;
Add a comment similar to the one above that this is overridden by the embedder?

http://codereview.chromium.org/9159013/diff/1/corelib/src/options.dart
File corelib/src/options.dart (right):

http://codereview.chromium.org/9159013/diff/1/corelib/src/options.dart#newcode26
corelib/src/options.dart:26: * Returns the path of the script being run.
To mirror the comment above: "being run in this isolate."?

[Bill Hesse, 2012-01-20 16:05:57]

Addressed comments.

http://codereview.chromium.org/9159013/diff/1/corelib/src/implementation/opti...
File corelib/src/implementation/options.dart (right):

http://codereview.chromium.org/9159013/diff/1/corelib/src/implementation/opti...
corelib/src/implementation/options.dart:20: // This arguments singleton is
overriden by the embedder if applicable.
On 2012/01/20 11:38:03, Mads Ager wrote:
> overridden?

written, written to.

http://codereview.chromium.org/9159013/diff/1/corelib/src/options.dart
File corelib/src/options.dart (right):

http://codereview.chromium.org/9159013/diff/1/corelib/src/options.dart#newcode26
corelib/src/options.dart:26: * Returns the path of the script being run.
On 2012/01/20 11:38:03, Mads Ager wrote:
> To mirror the comment above: "being run in this isolate."?

Done.

[Ivan Posva, 2012-01-20 16:29:40]

LGTM -ip