Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1073)

Issue 9150044: Record the elements on identifiers in the AST referring to types. (Closed)

Created:
8 years, 11 months ago by zundel
Modified:
8 years, 11 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, Brian Wilkerson, messick, danrubel
Visibility:
Public.

Description

Record the elements on identifiers in the AST referring to types. When dartc resolved a type, in the past it did not set the elements for the type on the AST ( you had to go through the type). This is a bit tedious in the IDE, so we are going to try to fill in more of the symbols in the AST. Committed: https://code.google.com/p/dart/source/detail?r=3449

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -2 lines) Patch
M compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java View 2 chunks +22 lines, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/Resolver.java View 3 chunks +4 lines, -1 line 0 comments Download
M compiler/javatests/com/google/dart/compiler/resolver/ResolverTestCase.java View 3 chunks +38 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
zundel
8 years, 11 months ago (2012-01-19 20:12:41 UTC) #1
scheglov
No tests? Is it possible to enable ResolverAuditVisitor, but report only failures to resolve in ...
8 years, 11 months ago (2012-01-19 20:23:57 UTC) #2
zundel
On 2012/01/19 20:23:57, scheglov wrote: > No tests? > Is it possible to enable ResolverAuditVisitor, ...
8 years, 11 months ago (2012-01-19 20:33:18 UTC) #3
scheglov
8 years, 11 months ago (2012-01-19 20:34:59 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698