Issue 9150036: Skip qualified identifiers that are part of ignored types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9150036: Skip qualified identifiers that are part of ignored types. (Closed)

Created:
8 years, 11 months ago by regis

Modified:
8 years, 11 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Skip qualified identifiers that are part of ignored types. Committed: https://code.google.com/p/dart/source/detail?r=3441

Patch Set 2 : '' #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -6 lines)			Patch
	M	runtime/vm/parser.h	View		2 chunks	+1 line, -1 line	0 comments	Download
	M	runtime/vm/parser.cc	View	1	5 chunks	+27 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hausner

LGTM https://chromiumcodereview.appspot.com/9150036/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://chromiumcodereview.appspot.com/9150036/diff/1/runtime/vm/parser.cc#newcode827 runtime/vm/parser.cc:827: // functions appearing in type tests with typedef's. ...

8 years, 11 months ago (2012-01-19 18:20:35 UTC) #2

regis

8 years, 11 months ago (2012-01-19 18:31:33 UTC) #3

Thanks

https://chromiumcodereview.appspot.com/9150036/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://chromiumcodereview.appspot.com/9150036/diff/1/runtime/vm/parser.cc#ne...
runtime/vm/parser.cc:827: // functions appearing in type tests with typedef's.
On 2012/01/19 18:20:35, hausner wrote:
> typedefs

Done.

Expand Messages | Collapse Messages

Issue 9150036: Skip qualified identifiers that are part of ignored types. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages