Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 9150031: Fix a couple of isolate-related memory leaks that show up a lot in valgrind output. (Closed)

Created:
8 years, 11 months ago by Mads Ager (google)
Modified:
8 years, 11 months ago
Reviewers:
hausner, Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix a couple of isolate-related memory leaks that show up a lot in valgrind output. R=hausner@google.com,iposva@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=3442

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M runtime/lib/isolate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/isolate.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (google)
8 years, 11 months ago (2012-01-19 14:56:58 UTC) #1
Ivan Posva
LGTM -ip
8 years, 11 months ago (2012-01-19 16:06:50 UTC) #2
hausner
8 years, 11 months ago (2012-01-19 16:29:04 UTC) #3
LGTM2. Thanks for finding the debugger leak.

Powered by Google App Engine
This is Rietveld 408576698